From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] drm/fb-helper: fix simple_return.cocci warnings Date: Fri, 19 Dec 2014 19:14:13 +0800 Message-ID: <20141219111413.GA17269@athens> References: <201412191911.BLNbzNHF%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C3156E4B2 for ; Fri, 19 Dec 2014 03:15:46 -0800 (PST) Content-Disposition: inline In-Reply-To: <201412191911.BLNbzNHF%fengguang.wu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabian Frederick , Zach Reizner , kbuild-all@01.org, Martin Koegler , Dave Airlie , Russell King List-Id: dri-devel@lists.freedesktop.org ZHJpdmVycy9ncHUvZHJtL2NpcnJ1cy9jaXJydXNfZmJkZXYuYzozMzA6MS00OiBXQVJOSU5HOiBl bmQgcmV0dXJucyBjYW4gYmUgc2ltcGlmaWVkCgogU2ltcGxpZnkgYSB0cml2aWFsIGlmLXJldHVy biBzZXF1ZW5jZS4gIFBvc3NpYmx5IGNvbWJpbmUgd2l0aCBhCiBwcmVjZWRpbmcgZnVuY3Rpb24g Y2FsbC4KR2VuZXJhdGVkIGJ5OiBzY3JpcHRzL2NvY2NpbmVsbGUvbWlzYy9zaW1wbGVfcmV0dXJu LmNvY2NpCgpDQzogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KU2lnbmVkLW9m Zi1ieTogRmVuZ2d1YW5nIFd1IDxmZW5nZ3Vhbmcud3VAaW50ZWwuY29tPgotLS0KCiBjaXJydXNf ZmJkZXYuYyB8ICAgIDYgKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDUg ZGVsZXRpb25zKC0pCgotLS0gYS9kcml2ZXJzL2dwdS9kcm0vY2lycnVzL2NpcnJ1c19mYmRldi5j CisrKyBiL2RyaXZlcnMvZ3B1L2RybS9jaXJydXMvY2lycnVzX2ZiZGV2LmMKQEAgLTMyNywxMSAr MzI3LDcgQEAgaW50IGNpcnJ1c19mYmRldl9pbml0KHN0cnVjdCBjaXJydXNfZGV2aQogCS8qIGRp c2FibGUgYWxsIHRoZSBwb3NzaWJsZSBvdXRwdXRzL2NydGNzIGJlZm9yZSBlbnRlcmluZyBLTVMg bW9kZSAqLwogCWRybV9oZWxwZXJfZGlzYWJsZV91bnVzZWRfZnVuY3Rpb25zKGNkZXYtPmRldik7 CiAKLQlyZXQgPSBkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnKCZnZmJkZXYtPmhlbHBlciwg YnBwX3NlbCk7Ci0JaWYgKHJldCkKLQkJcmV0dXJuIHJldDsKLQotCXJldHVybiAwOworCXJldHVy biBkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnKCZnZmJkZXYtPmhlbHBlciwgYnBwX3NlbCk7 CiB9CiAKIHZvaWQgY2lycnVzX2ZiZGV2X2Zpbmkoc3RydWN0IGNpcnJ1c19kZXZpY2UgKmNkZXYp Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbaLSLPr (ORCPT ); Fri, 19 Dec 2014 06:15:47 -0500 Received: from mga11.intel.com ([192.55.52.93]:20352 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbaLSLPq (ORCPT ); Fri, 19 Dec 2014 06:15:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="431153539" Date: Fri, 19 Dec 2014 19:14:13 +0800 From: kbuild test robot To: Thierry Reding Cc: kbuild-all@01.org, Daniel Vetter , David Airlie , Dave Airlie , Russell King , Zach Reizner , Fabian Frederick , Martin Koegler , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/fb-helper: fix simple_return.cocci warnings Message-ID: <20141219111413.GA17269@athens> References: <201412191911.BLNbzNHF%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201412191911.BLNbzNHF%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/gpu/drm/cirrus/cirrus_fbdev.c:330:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Thierry Reding Signed-off-by: Fengguang Wu --- cirrus_fbdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c +++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c @@ -327,11 +327,7 @@ int cirrus_fbdev_init(struct cirrus_devi /* disable all the possible outputs/crtcs before entering KMS mode */ drm_helper_disable_unused_functions(cdev->dev); - ret = drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel); - if (ret) - return ret; - - return 0; + return drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel); } void cirrus_fbdev_fini(struct cirrus_device *cdev)