From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init Date: Sat, 20 Dec 2014 13:25:15 -0800 Message-ID: <20141220212515.GA30589@kroah.com> References: <1419108374-7020-1-git-send-email-oded.gabbay@amd.com> <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTP id A99706E032 for ; Sat, 20 Dec 2014 13:25:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oded Gabbay Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBEZWMgMjAsIDIwMTQgYXQgMTA6NDY6MTJQTSArMDIwMCwgT2RlZCBHYWJiYXkgd3Jv dGU6Cj4gV2hlbiBhbWRrZmQgYW5kIHJhZGVvbiBhcmUgY29tcGlsZWQgaW5zaWRlIHRoZSBrZXJu ZWwgaW1hZ2UgKG5vdCBhcyBtb2R1bGVzKSwKPiByYWRlb24gd2lsbCBsb2FkIGJlZm9yZSBhbWRr ZmQgYW5kIHdpbGwgc2V0ICprZmQya2dkIHRvIGl0cyBpbnRlcmZhY2UKPiBzdHJ1Y3R1cmUuIFRo ZXJlZm9yZSwgd2UgbXVzdCBub3Qgc2V0ICprZmQya2dkIHRvIE5VTEwgd2hlbiBhbWRrZmQgaXMg bG9hZGVkCj4gYmVjYXVzZSBpdCB3aWxsIG92ZXJyaWRlIHJhZGVvbidzIGluaXRpYWxpemF0aW9u IGFuZCBjYXVzZSBrZXJuZWwgQlVHLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE9kZWQgR2FiYmF5IDxv ZGVkLmdhYmJheUBhbWQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9r ZmRfbW9kdWxlLmMgfCA1ICsrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k a2ZkL2tmZF9tb2R1bGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9tb2R1bGUu Ywo+IGluZGV4IDk1ZDVhZjEuLjIzNjU2MmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRrZmQva2ZkX21vZHVsZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRr ZmQva2ZkX21vZHVsZS5jCj4gQEAgLTM0LDcgKzM0LDcgQEAKPiAgI2RlZmluZSBLRkRfRFJJVkVS X01JTk9SCTcKPiAgI2RlZmluZSBLRkRfRFJJVkVSX1BBVENITEVWRUwJMAo+ICAKPiAtY29uc3Qg c3RydWN0IGtmZDJrZ2RfY2FsbHMgKmtmZDJrZ2Q7Cj4gK2NvbnN0IHN0cnVjdCBrZmQya2dkX2Nh bGxzICprZmQya2dkID0gTlVMTDsKClRoaXMgY2hhbmdlIGRvZXMgbm90aGluZywgdGhhdCBpcyB3 aGF0IHRoZSBvcmlnaW5hbCBjb2RlIGRpZCBhbHJlYWR5LgoKdGhhbmtzLAoKZ3JlZyBrLWgKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752190AbaLTVZW (ORCPT ); Sat, 20 Dec 2014 16:25:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50746 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbaLTVZV (ORCPT ); Sat, 20 Dec 2014 16:25:21 -0500 Date: Sat, 20 Dec 2014 13:25:15 -0800 From: Greg KH To: Oded Gabbay Cc: dri-devel@lists.freedesktop.org, David Airlie , Jerome Glisse , Joerg Roedel , linux-kernel@vger.kernel.org, John Bridgman , Alexander.Deucher@amd.com Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init Message-ID: <20141220212515.GA30589@kroah.com> References: <1419108374-7020-1-git-send-email-oded.gabbay@amd.com> <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote: > When amdkfd and radeon are compiled inside the kernel image (not as modules), > radeon will load before amdkfd and will set *kfd2kgd to its interface > structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded > because it will override radeon's initialization and cause kernel BUG. > > Signed-off-by: Oded Gabbay > --- > drivers/gpu/drm/amd/amdkfd/kfd_module.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c > index 95d5af1..236562f 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_module.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_module.c > @@ -34,7 +34,7 @@ > #define KFD_DRIVER_MINOR 7 > #define KFD_DRIVER_PATCHLEVEL 0 > > -const struct kfd2kgd_calls *kfd2kgd; > +const struct kfd2kgd_calls *kfd2kgd = NULL; This change does nothing, that is what the original code did already. thanks, greg k-h