All of lore.kernel.org
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: cocci@systeme.lip6.fr
Subject: [Cocci] how to debug missing match?
Date: Sun, 21 Dec 2014 10:53:38 +0100	[thread overview]
Message-ID: <20141221095337.GA1081@katana> (raw)

Hi

with linux kernel v3.18-rc1 and spatch version 1.0.0-rc22 with Python
support and with PCRE support from Debian:

~/Kernel/linux$ spatch -D report --sp-file scripts/coccinelle/api/platform_no_drv_owner.cocci arch/arm/mach-exynos/*.c

produces:

arch/arm/mach-exynos/pmu.c:994:3-8: No need to set .owner here. The core will do it.
diff = 
--- arch/arm/mach-exynos/pmu.c
+++ /tmp/cocci-output-25796-7e6ab9-pmu.c
@@ -991,7 +991,6 @@ static int exynos_pmu_probe(struct platf
 static struct platform_driver exynos_pmu_driver = {
 	.driver  = {
 		.name   = "exynos-pmu",
-		.owner	= THIS_MODULE,
 		.of_match_table = exynos_pmu_of_device_ids,
 	},
 	.probe = exynos_pmu_probe,

But:

~/Kernel/linux$ spatch -D report --sp-file scripts/coccinelle/api/platform_no_drv_owner.cocci drivers/macintosh/*.c

does not result in anything although three drivers should match IMO with
the same pattern as the pmu driver above. Both use
platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

Thanks,

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20141221/7b223621/attachment.asc>

             reply	other threads:[~2014-12-21  9:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-21  9:53 Wolfram Sang [this message]
2014-12-21 10:20 ` [Cocci] how to debug missing match? Wolfram Sang
2014-12-21 10:39   ` Julia Lawall
2014-12-21 10:51     ` Wolfram Sang
2014-12-21 10:55       ` Julia Lawall
2014-12-21 11:15   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141221095337.GA1081@katana \
    --to=wsa@the-dreams.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.