From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Guinot Subject: Re: [PATCH] leds: netxbig: fix oops at probe time Date: Mon, 22 Dec 2014 12:57:37 +0100 Message-ID: <20141222115737.GL19261@kw.sim.vm.gnt> References: <1417534330-13154-1-git-send-email-simon.guinot@sequanux.org> <20141211090400.GB18449@kw.sim.vm.gnt> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KDy5+/kaQUC2a3Gw" Return-path: Received: from vm1.sequanux.org ([188.165.36.56]:44140 "EHLO vm1.sequanux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457AbaLVL5k (ORCPT ); Mon, 22 Dec 2014 06:57:40 -0500 Content-Disposition: inline In-Reply-To: <20141211090400.GB18449@kw.sim.vm.gnt> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Bryan Wu Cc: Andrew Lunn , Jason Cooper , Johan Hovold , Vincent Donnefort , Richard Purdie , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, linux-leds@vger.kernel.org, Sebastian Hesselbarth --KDy5+/kaQUC2a3Gw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2014 at 10:04:00AM +0100, Simon Guinot wrote: > On Tue, Dec 02, 2014 at 04:32:10PM +0100, Simon Guinot wrote: > > This patch fixes a NULL pointer dereference on led_dat->mode_val. Due to > > this bug, a kernel oops can be observed at probe time on the LaCie 2Big > > and 5Big v2 boards: > >=20 > > Unable to handle kernel NULL pointer dereference at virtual address 000= 00008 > > [...] > > [] (netxbig_led_probe) from [] (platform_drv_probe+= 0x4c/0x9c) > > [] (platform_drv_probe) from [] (driver_probe_devic= e+0x98/0x25c) > > [] (driver_probe_device) from [] (__driver_attach+0= x8c/0x90) > > [] (__driver_attach) from [] (bus_for_each_dev+0x68= /0x94) > > [] (bus_for_each_dev) from [] (bus_add_driver+0x124= /0x1dc) > > [] (bus_add_driver) from [] (driver_register+0x78/0= xf8) > > [] (driver_register) from [] (do_one_initcall+0x80/= 0x1cc) > > [] (do_one_initcall) from [] (kernel_init_freeable+= 0xe4/0x1b4) > > [] (kernel_init_freeable) from [] (kernel_init+0xc/= 0xec) > > [] (kernel_init) from [] (ret_from_fork+0x14/0x24) > > [...] > >=20 > > This bug was introduced by commit 588a6a99286ae30afb1339d8bc2163517b1b7= dd1 > > ("leds: netxbig: fix attribute-creation race"). > >=20 > > Signed-off-by: Simon Guinot > > Cc: # 3.17+ > > --- > > drivers/leds/leds-netxbig.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > Hi Bryan, >=20 > Please apply up this patch. Hi Bryan, Is there any news about this patch on your side ? Jason, Andrew, Sebastian, Maybe this patch can go through the SoC branch ? Thanks in advance. Simon --KDy5+/kaQUC2a3Gw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlSYBzEACgkQgtp0PDeOcDoN7ACdHE9OAOrwDFY5nKusXknO77xQ SCkAn3QH/GnTgsN6g0gIqIO0vW1PBsi6 =FF1L -----END PGP SIGNATURE----- --KDy5+/kaQUC2a3Gw-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: simon.guinot@sequanux.org (Simon Guinot) Date: Mon, 22 Dec 2014 12:57:37 +0100 Subject: [PATCH] leds: netxbig: fix oops at probe time In-Reply-To: <20141211090400.GB18449@kw.sim.vm.gnt> References: <1417534330-13154-1-git-send-email-simon.guinot@sequanux.org> <20141211090400.GB18449@kw.sim.vm.gnt> Message-ID: <20141222115737.GL19261@kw.sim.vm.gnt> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 11, 2014 at 10:04:00AM +0100, Simon Guinot wrote: > On Tue, Dec 02, 2014 at 04:32:10PM +0100, Simon Guinot wrote: > > This patch fixes a NULL pointer dereference on led_dat->mode_val. Due to > > this bug, a kernel oops can be observed at probe time on the LaCie 2Big > > and 5Big v2 boards: > > > > Unable to handle kernel NULL pointer dereference at virtual address 00000008 > > [...] > > [] (netxbig_led_probe) from [] (platform_drv_probe+0x4c/0x9c) > > [] (platform_drv_probe) from [] (driver_probe_device+0x98/0x25c) > > [] (driver_probe_device) from [] (__driver_attach+0x8c/0x90) > > [] (__driver_attach) from [] (bus_for_each_dev+0x68/0x94) > > [] (bus_for_each_dev) from [] (bus_add_driver+0x124/0x1dc) > > [] (bus_add_driver) from [] (driver_register+0x78/0xf8) > > [] (driver_register) from [] (do_one_initcall+0x80/0x1cc) > > [] (do_one_initcall) from [] (kernel_init_freeable+0xe4/0x1b4) > > [] (kernel_init_freeable) from [] (kernel_init+0xc/0xec) > > [] (kernel_init) from [] (ret_from_fork+0x14/0x24) > > [...] > > > > This bug was introduced by commit 588a6a99286ae30afb1339d8bc2163517b1b7dd1 > > ("leds: netxbig: fix attribute-creation race"). > > > > Signed-off-by: Simon Guinot > > Cc: # 3.17+ > > --- > > drivers/leds/leds-netxbig.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > Hi Bryan, > > Please apply up this patch. Hi Bryan, Is there any news about this patch on your side ? Jason, Andrew, Sebastian, Maybe this patch can go through the SoC branch ? Thanks in advance. Simon -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: