All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <pza@pengutronix.de>
To: "Frédéric Sureau" <frederic.sureau@vodalys.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>,
	Fabio Estevam <festevam@gmail.com>,
	linux-media <linux-media@vger.kernel.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: coda: Unable to use encoder video_bitrate
Date: Mon, 22 Dec 2014 17:02:24 +0100	[thread overview]
Message-ID: <20141222160224.GC32333@pengutronix.de> (raw)
In-Reply-To: <549837A4.2060605@vodalys.com>

Hi Frédéric,

On Mon, Dec 22, 2014 at 04:24:20PM +0100, Frédéric Sureau wrote:
> Thanks for the patch!
> It works fine now after forcing framerate to 30fps (which seems to
> be hardcoded in the driver)

That is a good point, rate control can only work if the encoder has
an idea about the framerate. I've sent a patch that allows to use
VIDIOC_S_PARM to set it:
"[media] coda: Use S_PARM to set nominal framerate for h.264 encoder"

regards
Philipp

  parent reply	other threads:[~2014-12-22 16:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 16:44 coda: Unable to use encoder video_bitrate Frédéric Sureau
2014-12-18 16:52 ` Philipp Zabel
2014-12-18 16:55   ` Jean-Michel Hautbois
2014-12-18 17:09     ` Philipp Zabel
2014-12-18 17:10       ` Jean-Michel Hautbois
2014-12-19 10:28         ` Philipp Zabel
2014-12-19 10:33           ` Jean-Michel Hautbois
2014-12-22 15:24   ` Frédéric Sureau
2014-12-22 15:28     ` Nicolas Dufresne
2014-12-22 16:02     ` Philipp Zabel [this message]
2014-12-22 16:06       ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141222160224.GC32333@pengutronix.de \
    --to=pza@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=frederic.sureau@vodalys.com \
    --cc=jean-michel.hautbois@vodalys.com \
    --cc=linux-media@vger.kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.