diff for duplicates of <20141222191452.GA20295@node.dhcp.inet.fi> diff --git a/a/1.txt b/N1/1.txt index cf64d3a..e9caf22 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -45,3 +45,54 @@ Konstantin, you've modified untrack_pfn() back in 2012 to change For now, I would propose to revert the commit and probably re-introduce it after v3.19: + +>From 14392c69fcfeeda34eb9f75d983dad32698cdd5c Mon Sep 17 00:00:00 2001 +From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> +Date: Mon, 22 Dec 2014 21:01:54 +0200 +Subject: [PATCH] Revert "mm/memory.c: share the i_mmap_rwsem" + +This reverts commit c8475d144abb1e62958cc5ec281d2a9e161c1946. + +There are several[1][2] of bug reports which points to this commit as potential +cause[3]. + +Let's revert it until we figure out what's going on. + +[1] https://lkml.org/lkml/2014/11/14/342 +[2] https://lkml.org/lkml/2014/12/22/213 +[3] https://lkml.org/lkml/2014/12/9/741 + +Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> +Reported-by: Sasha Levin <sasha.levin@oracle.com> +Cc: Davidlohr Bueso <dave@stgolabs.net> +Cc: Hugh Dickins <hughd@google.com> +Cc: Oleg Nesterov <oleg@redhat.com> +Cc: Peter Zijlstra (Intel) <peterz@infradead.org> +Cc: Rik van Riel <riel@redhat.com> +Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> +Cc: Mel Gorman <mgorman@suse.de> +--- + mm/memory.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/mm/memory.c b/mm/memory.c +index 649e7d440bd7..ca920d1fd314 100644 +--- a/mm/memory.c ++++ b/mm/memory.c +@@ -2378,12 +2378,12 @@ void unmap_mapping_range(struct address_space *mapping, + details.last_index = ULONG_MAX; + + +- i_mmap_lock_read(mapping); ++ i_mmap_lock_write(mapping); + if (unlikely(!RB_EMPTY_ROOT(&mapping->i_mmap))) + unmap_mapping_range_tree(&mapping->i_mmap, &details); + if (unlikely(!list_empty(&mapping->i_mmap_nonlinear))) + unmap_mapping_range_list(&mapping->i_mmap_nonlinear, &details); +- i_mmap_unlock_read(mapping); ++ i_mmap_unlock_write(mapping); + } + EXPORT_SYMBOL(unmap_mapping_range); + +-- + Kirill A. Shutemov diff --git a/a/content_digest b/N1/content_digest index 1024cc5..a30e3aa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,6 +11,7 @@ LKML <linux-kernel@vger.kernel.org> Andrew Morton <akpm@linux-foundation.org> Dave Jones <davej@redhat.com> + dave@stgolabs.net Hugh Dickins <hughd@google.com> Oleg Nesterov <oleg@redhat.com> Peter Zijlstra <peterz@infradead.org> @@ -66,6 +67,57 @@ "->vm_flags. Any coments?\n" "\n" "For now, I would propose to revert the commit and probably re-introduce it\n" - after v3.19: + "after v3.19:\n" + "\n" + ">From 14392c69fcfeeda34eb9f75d983dad32698cdd5c Mon Sep 17 00:00:00 2001\n" + "From: \"Kirill A. Shutemov\" <kirill.shutemov@linux.intel.com>\n" + "Date: Mon, 22 Dec 2014 21:01:54 +0200\n" + "Subject: [PATCH] Revert \"mm/memory.c: share the i_mmap_rwsem\"\n" + "\n" + "This reverts commit c8475d144abb1e62958cc5ec281d2a9e161c1946.\n" + "\n" + "There are several[1][2] of bug reports which points to this commit as potential\n" + "cause[3].\n" + "\n" + "Let's revert it until we figure out what's going on.\n" + "\n" + "[1] https://lkml.org/lkml/2014/11/14/342\n" + "[2] https://lkml.org/lkml/2014/12/22/213\n" + "[3] https://lkml.org/lkml/2014/12/9/741\n" + "\n" + "Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>\n" + "Reported-by: Sasha Levin <sasha.levin@oracle.com>\n" + "Cc: Davidlohr Bueso <dave@stgolabs.net>\n" + "Cc: Hugh Dickins <hughd@google.com>\n" + "Cc: Oleg Nesterov <oleg@redhat.com>\n" + "Cc: Peter Zijlstra (Intel) <peterz@infradead.org>\n" + "Cc: Rik van Riel <riel@redhat.com>\n" + "Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>\n" + "Cc: Mel Gorman <mgorman@suse.de>\n" + "---\n" + " mm/memory.c | 4 ++--\n" + " 1 file changed, 2 insertions(+), 2 deletions(-)\n" + "\n" + "diff --git a/mm/memory.c b/mm/memory.c\n" + "index 649e7d440bd7..ca920d1fd314 100644\n" + "--- a/mm/memory.c\n" + "+++ b/mm/memory.c\n" + "@@ -2378,12 +2378,12 @@ void unmap_mapping_range(struct address_space *mapping,\n" + " \t\tdetails.last_index = ULONG_MAX;\n" + " \n" + " \n" + "-\ti_mmap_lock_read(mapping);\n" + "+\ti_mmap_lock_write(mapping);\n" + " \tif (unlikely(!RB_EMPTY_ROOT(&mapping->i_mmap)))\n" + " \t\tunmap_mapping_range_tree(&mapping->i_mmap, &details);\n" + " \tif (unlikely(!list_empty(&mapping->i_mmap_nonlinear)))\n" + " \t\tunmap_mapping_range_list(&mapping->i_mmap_nonlinear, &details);\n" + "-\ti_mmap_unlock_read(mapping);\n" + "+\ti_mmap_unlock_write(mapping);\n" + " }\n" + " EXPORT_SYMBOL(unmap_mapping_range);\n" + " \n" + "-- \n" + Kirill A. Shutemov -f656d9db5ff70231de3c9abc1880c4a3cc065f81fee5a066622468ccb38b837f +351b817c57212c1a2c12ac3990ccb2783538fa94743810f79bbfcf6392c8b5f4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.