From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ben Walton <bdwalton@gmail.com>,
dturner@twopensource.com, git@vger.kernel.org
Subject: Re: [PATCH] Use wc instead of awk to count subtrees in t0090-cache-tree
Date: Mon, 22 Dec 2014 15:38:07 -0800 [thread overview]
Message-ID: <20141222233807.GU29365@google.com> (raw)
In-Reply-To: <xmqq8uhz6za0.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>> From: Ben Walton <bdwalton@gmail.com>
>>
>> The awk statements previously used in this test weren't compatible
>> with the native versions of awk on Solaris:
>>
>> echo "dir" | /bin/awk -v c=0 '$1 {++c} END {print c}'
>> awk: syntax error near line 1
>> awk: bailing out near line 1
If I were doing it, I'd leave the above four lines out --- they are
describing an unrelated problem. I wonder if we should make the test
harness respect SANE_TOOL_PATH to avoid that kind of problem in the
future.
[...]
> heh, not like that without updating the subject, perhaps like this:
>
> Subject: t0090: tweak awk statement for Solaris /usr/xpg4/bin/awk
With the updated subject,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
next prev parent reply other threads:[~2014-12-22 23:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 17:52 [PATCH] Use wc instead of awk to count subtrees in t0090-cache-tree Ben Walton
2014-12-22 21:45 ` Junio C Hamano
2014-12-22 22:02 ` Jonathan Nieder
2014-12-22 22:26 ` Junio C Hamano
2014-12-22 22:01 ` Jonathan Nieder
2014-12-22 23:25 ` Junio C Hamano
2014-12-22 23:27 ` Junio C Hamano
2014-12-22 23:38 ` Jonathan Nieder [this message]
2014-12-23 18:26 ` Junio C Hamano
2014-12-22 23:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222233807.GU29365@google.com \
--to=jrnieder@gmail.com \
--cc=bdwalton@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.