From: Fam Zheng <famz@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/19] Block patches
Date: Tue, 23 Dec 2014 10:15:28 +0800 [thread overview]
Message-ID: <20141223021528.GG4021@ad.nay.redhat.com> (raw)
In-Reply-To: <CAFEAcA9tQfrwq3z+VcdZq3ceukEuQzo6frZLfWCPiUhu-aT7jA@mail.gmail.com>
On Mon, 12/22 12:22, Peter Maydell wrote:
> On 22 December 2014 at 12:07, Peter Maydell <peter.maydell@linaro.org> wrote:
> > Something very odd is happening here: why are all the "r"s apparently
> > missing from those error messages?
>
> Looks like the result of using GNU sed-isms in some of the filters. On OSX:
>
> $ echo "art trick" | sed -e 's/\r//g'
> at tick
>
> On Linux with GNU sed:
> $ echo "art trick" | sed -e 's/\r//g'
> art trick
>
> This likely breaks on the BSDs too. I suspect these scripts need
> a careful overhaul before we can add them to 'make check' :-(
>
Oops! Thanks Peter, I'll take care of it and respin. We should drop these
patches from this PULL for now.
Fam
next prev parent reply other threads:[~2014-12-23 2:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 16:34 [Qemu-devel] [PULL 00/19] Block patches Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 01/19] qemu-iotests: Remove 091 from quick group Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 02/19] qemu-iotests: Speed up make check-block Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 03/19] tests/Makefile: Add check-block to make check Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 04/19] block: mark AioContext as recursive Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 05/19] block: do not allocate an iovec per read of a growable/zero_after_eof BDS Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 06/19] block: replace g_new0 with g_new for bottom half allocation Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 07/19] checkpatch: Brace handling on multi-line condition Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 08/19] block: Get full backing filename from string Kevin Wolf
2014-12-19 16:34 ` [Qemu-devel] [PULL 09/19] block: JSON filenames and relative backing files Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 10/19] block: Relative backing file for image creation Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 11/19] block/vmdk: Relative backing file for creation Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 12/19] iotests: Add test for relative backing file names Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 13/19] qapi: Fix document for BlockStats.node-name Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 14/19] block: fix spoiling all dirty bitmaps by mirror and migration Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 15/19] qapi: Comment version info in TransactionAction Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 16/19] qmp: Add command 'blockdev-backup' Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 17/19] block: Add blockdev-backup to transaction Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 18/19] qemu-iotests: Test blockdev-backup in 055 Kevin Wolf
2014-12-19 16:35 ` [Qemu-devel] [PULL 19/19] iotests: Filter out "I/O thread spun..." warning Kevin Wolf
2014-12-22 11:14 ` [Qemu-devel] [PULL 00/19] Block patches Peter Maydell
2014-12-22 12:07 ` Peter Maydell
2014-12-22 12:22 ` Peter Maydell
2014-12-23 2:15 ` Fam Zheng [this message]
2015-01-05 11:55 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2015-01-05 11:51 Stefan Hajnoczi
2014-12-12 17:09 Stefan Hajnoczi
2014-12-15 11:11 ` Peter Maydell
2014-03-07 13:32 Kevin Wolf
2014-03-08 12:40 ` Peter Maydell
2012-09-24 14:26 Kevin Wolf
2012-09-25 23:26 ` Anthony Liguori
2011-10-21 17:18 Kevin Wolf
2011-10-24 16:19 ` Anthony Liguori
2010-06-15 14:19 Kevin Wolf
2010-06-15 14:26 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223021528.GG4021@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.