All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Suykov <alex.suykov@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: support target-to-host SCM_CREDENTIALS
Date: Tue, 23 Dec 2014 07:52:46 +0200	[thread overview]
Message-ID: <20141223055246.GA31216@vostro> (raw)
In-Reply-To: <20141223015957.GC4021@ad.nay.redhat.com>

Tue, Dec 23, 2014 at 09:59:57AM +0800, Fam Zheng wrote:

> On Sun, 12/21 13:02, Alex Suykov wrote:
> > When passing ancillary data through a unix socket, handle
> > credentials properly instead of doing a simple copy and
> > issuing a warning.
> > 
> > Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
> > ---
...
> > -            gemu_log("Unsupported ancillary data: %d/%d\n", cmsg->cmsg_level, cmsg->cmsg_type);
...
> > +            gemu_log("Unsupported ancillary data: %d/%d\n", cmsg->cmsg_level, cmsg->cmsg_type);
...
> 
> I didn't review the code but checkpatch.pl complains about a few lines over 80
> characters.

The patch does not change the length of the longest line in that function,
just moves it around. So my guess was that mixing semantic changes
and reformatting is not a good idea.

Sending checkpatch-compliant v2.

      reply	other threads:[~2014-12-23  5:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-21 11:02 [Qemu-devel] [PATCH] linux-user: support target-to-host SCM_CREDENTIALS Alex Suykov
2014-12-23  1:59 ` Fam Zheng
2014-12-23  5:52   ` Alex Suykov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141223055246.GA31216@vostro \
    --to=alex.suykov@gmail.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.