From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47}
Date: Tue, 23 Dec 2014 16:12:16 -0500 [thread overview]
Message-ID: <20141223211216.GC13304@peff.net> (raw)
In-Reply-To: <xmqqr3vq13mo.fsf@gitster.dls.corp.google.com>
On Tue, Dec 23, 2014 at 01:02:23PM -0800, Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> >> +++ b/t/t1450-fsck.sh
> > [...]
> >> + git fsck 2>err &&
> >> + cat err &&
> >> + ! test -s err
> >
> > Nit: if this said
> >
> > test_line_count = 0 err
> >
> > then the error message would be more obvious when it fails with
> > --verbose.
>
> That's a good suggestion, I think. This is meant to apply on top of
> d08c13b, and we already had test_line_count back then.
>
> So far I collected these follow-ups to squash into Peff's patch.
They all look good to me. Thanks.
-Peff
next prev parent reply other threads:[~2014-12-23 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 8:45 [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47} Jeff King
2014-12-23 15:24 ` Torsten Bögershausen
2014-12-23 18:17 ` Junio C Hamano
2014-12-23 18:18 ` Jeff King
2014-12-23 20:14 ` Jonathan Nieder
2014-12-23 21:02 ` Junio C Hamano
2014-12-23 21:12 ` Jeff King [this message]
2014-12-23 21:09 ` Jeff King
2014-12-23 20:31 ` Johannes Sixt
2014-12-23 21:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223211216.GC13304@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.