All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] dmaengine: rcar-audmapp: independent from SH_DMAE_BASE v2
Date: Wed, 24 Dec 2014 05:35:51 +0000	[thread overview]
Message-ID: <20141224052351.GS16827@intel.com> (raw)
In-Reply-To: <87vblknmw3.wl%kuninori.morimoto.gx@renesas.com>

On Wed, Dec 24, 2014 at 01:39:05AM +0000, Kuninori Morimoto wrote:
> 
> Hi Vinod, Laurent
> 
> > > > The second DMA controller is specific to the sound subsystem. I thus wonder if 
> > > > the additional complexity of supporting it through the DMA engine API (both in 
> > > > terms of code complexity on the DMA driver side and the sound driver side and 
> > > > in terms of DT bindings complexity) is worth it, or if it would be simpler and 
> > > > cleaner to support it with a driver specific to R-Car sound. You're more 
> > > > knowledgeable than I am on the subject, so I'll trust your judgment.
> > > 
> > > Yes, I agree to your opinion. R-Car DMAC should keep "general-purpose" DMA engine.
> > > It is easy to control if 1st/2nd DMA was separated from sound driver point of view.
> > > I guess sound HW which needs 2 DMAC is very rare case(?). I want "keep it simple"
> > > 
> > > Vinod, this means, we want to have 2 different DMA (= 1st/2nd) for sound.
> > > 1st DMA is general DMAC, 2nd DMA is sound specific DMAC.
> > > What is you opinion ?
> > I think this makes sense. Going thru the driver, it was clear that we were
> > not really gaining anything for using dmaengine API here. So agree that lets
> > use dmanegine for 1st dmac thru dmaengine library and then configure this in
> > your sound driver..
> 
> Thank you for your opinion.
> My understanding is that we can replace rcar-audmapp driver same as before.
Use my next to rebase
> Current DMAEngine branch has fixup(?) branch, and we need to rebase to it.
> And, this 2nd DMA needs 1st DMA which was created by Laurent.
> So, I will send v3 patch if Laurent's DMA driver was accepted
I have the PULL request from Laurent, should be able to process todays

-- 
~Vinod


      parent reply	other threads:[~2014-12-24  5:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  4:34 [PATCH 2/2 v2] dmaengine: rcar-audmapp: independent from SH_DMAE_BASE v2 Kuninori Morimoto
2014-12-10  5:58 ` Vinod Koul
2014-12-10  7:05 ` Kuninori Morimoto
2014-12-11  5:17 ` Vinod Koul
2014-12-11  5:31 ` Kuninori Morimoto
2014-12-15 10:31 ` Kuninori Morimoto
2014-12-15 14:54 ` Vinod Koul
2014-12-16  0:08 ` Kuninori Morimoto
2014-12-16  6:58 ` Vinod Koul
2014-12-16  9:03 ` Kuninori Morimoto
2014-12-16  9:11 ` Kuninori Morimoto
2014-12-16 16:45 ` Vinod Koul
2014-12-16 16:51 ` Vinod Koul
2014-12-16 19:41 ` Laurent Pinchart
2014-12-17  0:27 ` Kuninori Morimoto
2014-12-18 20:49 ` Laurent Pinchart
2014-12-19  0:27 ` Kuninori Morimoto
2014-12-22 15:26 ` Vinod Koul
2014-12-24  1:39 ` Kuninori Morimoto
2014-12-24  5:35 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141224052351.GS16827@intel.com \
    --to=vinod.koul@intel.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.