From: Steve James <ste@junkomatic.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] leveldb: new package
Date: Wed, 24 Dec 2014 12:25:54 +0000 [thread overview]
Message-ID: <201412241225.54658.ste@junkomatic.net> (raw)
In-Reply-To: <1419418559-23870-1-git-send-email-ste@junkomatic.net>
On Wednesday 24 Dec 2014 10:55:59 Steve James wrote:
> Adds new package: leveldb
>
> LevelDB is a fast key-value storage library written at Google that
> provides an ordered mapping from string keys to string values.
>
--snip--
> +
> +TARGET_CFLAGS += $(LEVELDB_CFLAGS)
> +TARGET_CXXFLAGS += $(LEVELDB_CFLAGS)
> +TARGET_MAKE_ARGS += $(LEVELDB_MAKE_ARGS)
> +
--snip--
Hang on, have I done something evil there? I'm working on another package now
and these flags are leaking into it. Looks like apending to TARGET_CFLAGS is
a no-no. So the rule to follow is: all Make macros should be scoped with the
package name. What I wanted to do was add to the value of CFLAGS as passed
by TARGET_CONFIGURE_OPTS. I'm looking for the right way to do that...
Steve.
next parent reply other threads:[~2014-12-24 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1419418559-23870-1-git-send-email-ste@junkomatic.net>
2014-12-24 12:25 ` Steve James [this message]
2014-12-24 13:31 ` [Buildroot] [PATCH v3] leveldb: new package Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412241225.54658.ste@junkomatic.net \
--to=ste@junkomatic.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.