All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Michal Hocko" <mhocko@suse.cz>,
	"Vladimir Davydov" <vdavydov@parallels.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	蔡正龙 <zhenglong.cai@cs2c.com.cn>,
	"Bertrand Jacquin" <beber@meleeweb.net>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	"Fabian Frederick" <fabf@skynet.be>,
	"Andy Lutomirski" <luto@amacapital.net>,
	"Pranith Kumar" <bobby.prani@gmail.com>,
	"Peter Foley" <pefoley2@pefoley.com>,
	"Mel Gorman" <mgorman@suse.de>,
	"Clark Williams" <clark.williams@gmail.com>
Subject: Re: [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU
Date: Wed, 24 Dec 2014 10:00:00 -0800	[thread overview]
Message-ID: <20141224180000.GF11609@linux.vnet.ibm.com> (raw)
In-Reply-To: <1419414940-5082-1-git-send-email-laijs@cn.fujitsu.com>

On Wed, Dec 24, 2014 at 05:55:28PM +0800, Lai Jiangshan wrote:
> The 48a7639ce80c ("rcu: Make callers awaken grace-period kthread")
> removed the irq_work_queue(), so the TREE_RCU doesn't need
> irq work any more.
> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>

Good catch, queued for 3.20.  Thank you!

							Thanx, Paul

> ---
>  init/Kconfig      |    2 --
>  kernel/rcu/tree.h |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 9afb971..39b4313 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -470,7 +470,6 @@ choice
>  config TREE_RCU
>  	bool "Tree-based hierarchical RCU"
>  	depends on !PREEMPT && SMP
> -	select IRQ_WORK
>  	help
>  	  This option selects the RCU implementation that is
>  	  designed for very large SMP system with hundreds or
> @@ -480,7 +479,6 @@ config TREE_RCU
>  config PREEMPT_RCU
>  	bool "Preemptible tree-based hierarchical RCU"
>  	depends on PREEMPT
> -	select IRQ_WORK
>  	help
>  	  This option selects the RCU implementation that is
>  	  designed for very large SMP systems with hundreds or
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 8e7b184..a47a13c 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -27,7 +27,6 @@
>  #include <linux/threads.h>
>  #include <linux/cpumask.h>
>  #include <linux/seqlock.h>
> -#include <linux/irq_work.h>
> 
>  /*
>   * Define shape of hierarchy based on NR_CPUS, CONFIG_RCU_FANOUT, and
> -- 
> 1.7.4.4
> 


      reply	other threads:[~2014-12-24 18:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-24  9:55 [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU Lai Jiangshan
2014-12-24 18:00 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141224180000.GF11609@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=beber@meleeweb.net \
    --cc=bobby.prani@gmail.com \
    --cc=clark.williams@gmail.com \
    --cc=fabf@skynet.be \
    --cc=geert@linux-m68k.org \
    --cc=hannes@cmpxchg.org \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mcgrof@suse.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=pefoley2@pefoley.com \
    --cc=rostedt@goodmis.org \
    --cc=vdavydov@parallels.com \
    --cc=zhenglong.cai@cs2c.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.