From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3z6J-0002Gy-Lw for qemu-devel@nongnu.org; Wed, 24 Dec 2014 22:28:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3z6D-00037K-5P for qemu-devel@nongnu.org; Wed, 24 Dec 2014 22:28:35 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:45495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3z6C-00035m-Gm for qemu-devel@nongnu.org; Wed, 24 Dec 2014 22:28:29 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Dec 2014 13:28:24 +1000 Date: Thu, 25 Dec 2014 14:18:33 +1100 From: Gavin Shan Message-ID: <20141225031833.GB5659@shangw> References: <1418602508-30845-1-git-send-email-gwshan@linux.vnet.ibm.com> <1418602508-30845-2-git-send-email-gwshan@linux.vnet.ibm.com> <20141223042458.GE4576@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141223042458.GE4576@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v13 1/3] spapr_pci: Make find_phb()/find_dev() public Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: agraf@suse.de, aik@ozlabs.ru, qemu-devel@nongnu.org, Gavin Shan , alex.williamson@redhat.com, qemu-ppc@nongnu.org On Tue, Dec 23, 2014 at 03:24:58PM +1100, David Gibson wrote: >On Mon, Dec 15, 2014 at 11:15:06AM +1100, Gavin Shan wrote: >> From: Alexey Kardashevskiy >> >> This makes find_phb()/find_dev() public and changed its names >> to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to >> be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) > >I don't actually see the other patches in this series using find_phb() >or find_dev() outside of spapr_pci.c, so this change doesn't seem to >be relevant to the series. > Yep, My patches were based on Alexey's "DDW" feature, which seems not be merged to Alex Graf's tree yet. This patch isn't related any more and I'll drop it in next version. Thanks, Gavin >-- >David Gibson | I'll have my music baroque, and my code >david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! >http://www.ozlabs.org/~dgibson