diff for duplicates of <20141226110649.GC4700@anne> diff --git a/a/1.txt b/N1/1.txt index 3a58b38..182f189 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -16,7 +16,7 @@ On Thu, Dec 25, 2014 at 02:08:12PM +0100, Sebastian Hesselbarth wrote: > > > >The third led is wired to show the SATA activity on the two drives. > > -> >Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com> +> >Signed-off-by: Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org> > > Evgeni, > @@ -59,7 +59,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+/* > >+ * Device Tree file for Seagate BlackArmor NAS220 > >+ * -> >+ * Copyright (C) 2014 Evgeni Dobrev <evgeni@studio-punkt.com> +> >+ * Copyright (C) 2014 Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org> > >+ * > >+ * Licensed under GPLv2 or later. > >+ */ @@ -93,8 +93,8 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ stdout-path = &uart0; > >+ }; > >+ -> >+ ocp at f1000000 { -> >+ pinctrl: pin-controller at 10000 { +> >+ ocp@f1000000 { +> >+ pinctrl: pin-controller@10000 { > > v3.19 should already have a label for the common pinctrl node. > Please do not replay the bus structure but use a node reference @@ -149,7 +149,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > Nice! Can you also clarify if TX/RX are as seen from the SoC or > remote end? > -> >+ serial at 12000 { +> >+ serial@12000 { > > Please use node references where possible, IIRC v3.19 should have > labels for serial, sata, and i2c. Avoid to replay the bus structure. @@ -157,7 +157,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ status = "okay"; > >+ }; > >+ -> >+ sata at 80000 { +> >+ sata@80000 { > >+ status = "okay"; > >+ nr-ports = <2>; > @@ -167,14 +167,14 @@ thank you for your review. I will make the changes you suggest and resubmit. > > >+ }; > >+ -> >+ i2c at 11000 { +> >+ i2c@11000 { > >+ status = "okay"; -> >+ adt7476: adt7476a at 2e { +> >+ adt7476: adt7476a@2e { > > I know we have a lot of bad examples, but: node names should reflect > device function, not device name, i.e. > -> adt7476: thermal at 2e { +> adt7476: thermal@2e { > ... > }; > @@ -194,7 +194,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > > Add a blank line between nodes. > -> >+ button at 1{ +> >+ button@1{ > >+ label = "Reset push button"; > > Reduce label to "Reset" and "Power" below. @@ -202,7 +202,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ linux,code = <KEY_POWER>; > >+ gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>; > >+ }; -> >+ button at 2{ +> >+ button@2{ > >+ label = "Power push button"; > >+ linux,code = <KEY_SLEEP>; > >+ gpios = <&gpio0 26 GPIO_ACTIVE_LOW>; @@ -228,7 +228,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ pinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>; > >+ pinctrl-names = "default"; > >+ -> >+ sata0_power: regulator at 1 { +> >+ sata0_power: regulator@1 { > >+ compatible = "regulator-fixed"; > >+ reg = <1>; > >+ regulator-name = "SATA0 Power"; @@ -244,7 +244,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > > >+ }; > >+ -> >+ sata1_power: regulator at 2 { +> >+ sata1_power: regulator@2 { > >+ compatible = "regulator-fixed"; > >+ reg = <2>; > >+ regulator-name = "SATA1 Power"; @@ -267,7 +267,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ > >+&mdio { > >+ status = "okay"; -> >+ ethphy0: ethernet-phy at 8 { +> >+ ethphy0: ethernet-phy@8 { > >+ reg = <8>; > >+ }; > @@ -277,7 +277,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ > >+ð0 { > >+ status = "okay"; -> >+ ethernet0-port at 0 { +> >+ ethernet0-port@0 { > >+ phy-handle = <ðphy0>; > >+ }; > >+}; @@ -285,7 +285,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > > Overall, this look fine to me, with the nits taken care of > -> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> +> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Thanks! > @@ -293,3 +293,7 @@ thank you for your review. I will make the changes you suggest and resubmit. Thanks, evgeni +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index c03a97f..412ed97 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,18 @@ "ref\020141215203855.GA28940@anne\0" "ref\020141222125750.GA29163@anne\0" "ref\0549C0C3C.8060601@gmail.com\0" - "From\0evgeni@studio-punkt.com (Evgeni Dobrev)\0" - "Subject\0[PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" + "ref\0549C0C3C.8060601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" + "From\0Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>\0" + "Subject\0Re: [PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" "Date\0Fri, 26 Dec 2014 12:06:49 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Cc\0devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> + Sebastian Hesselbarth <sebastian.hesselbarth-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> + Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + " Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>\0" "\00:1\0" "b\0" "Hello Sebastian,\n" @@ -25,7 +33,7 @@ "> >\n" "> >The third led is wired to show the SATA activity on the two drives.\n" "> >\n" - "> >Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>\n" + "> >Signed-off-by: Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>\n" "> \n" "> Evgeni,\n" "> \n" @@ -68,7 +76,7 @@ "> >+/*\n" "> >+ * Device Tree file for Seagate BlackArmor NAS220\n" "> >+ *\n" - "> >+ * Copyright (C) 2014 Evgeni Dobrev <evgeni@studio-punkt.com>\n" + "> >+ * Copyright (C) 2014 Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>\n" "> >+ *\n" "> >+ * Licensed under GPLv2 or later.\n" "> >+ */\n" @@ -102,8 +110,8 @@ "> >+\t\tstdout-path = &uart0;\n" "> >+\t};\n" "> >+\n" - "> >+\tocp at f1000000 {\n" - "> >+\t\tpinctrl: pin-controller at 10000 {\n" + "> >+\tocp@f1000000 {\n" + "> >+\t\tpinctrl: pin-controller@10000 {\n" "> \n" "> v3.19 should already have a label for the common pinctrl node.\n" "> Please do not replay the bus structure but use a node reference\n" @@ -158,7 +166,7 @@ "> Nice! Can you also clarify if TX/RX are as seen from the SoC or\n" "> remote end?\n" "> \n" - "> >+\t\tserial at 12000 {\n" + "> >+\t\tserial@12000 {\n" "> \n" "> Please use node references where possible, IIRC v3.19 should have\n" "> labels for serial, sata, and i2c. Avoid to replay the bus structure.\n" @@ -166,7 +174,7 @@ "> >+\t\t\tstatus = \"okay\";\n" "> >+\t\t};\n" "> >+\n" - "> >+\t\tsata at 80000 {\n" + "> >+\t\tsata@80000 {\n" "> >+\t\t\tstatus = \"okay\";\n" "> >+\t\t\tnr-ports = <2>;\n" "> \n" @@ -176,14 +184,14 @@ "> \n" "> >+\t\t};\n" "> >+\n" - "> >+\t\ti2c at 11000 {\n" + "> >+\t\ti2c@11000 {\n" "> >+\t\t\tstatus = \"okay\";\n" - "> >+\t\t\tadt7476: adt7476a at 2e {\n" + "> >+\t\t\tadt7476: adt7476a@2e {\n" "> \n" "> I know we have a lot of bad examples, but: node names should reflect\n" "> device function, not device name, i.e.\n" "> \n" - "> adt7476: thermal at 2e {\n" + "> adt7476: thermal@2e {\n" "> \t...\n" "> };\n" "> \n" @@ -203,7 +211,7 @@ "> \n" "> Add a blank line between nodes.\n" "> \n" - "> >+\t\tbutton at 1{\n" + "> >+\t\tbutton@1{\n" "> >+\t\t\tlabel = \"Reset push button\";\n" "> \n" "> Reduce label to \"Reset\" and \"Power\" below.\n" @@ -211,7 +219,7 @@ "> >+\t\t\tlinux,code = <KEY_POWER>;\n" "> >+\t\t\tgpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;\n" "> >+\t\t};\n" - "> >+\t\tbutton at 2{\n" + "> >+\t\tbutton@2{\n" "> >+\t\t\tlabel = \"Power push button\";\n" "> >+\t\t\tlinux,code = <KEY_SLEEP>;\n" "> >+\t\t\tgpios = <&gpio0 26 GPIO_ACTIVE_LOW>;\n" @@ -237,7 +245,7 @@ "> >+\t\tpinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>;\n" "> >+\t\tpinctrl-names = \"default\";\n" "> >+\n" - "> >+\t\tsata0_power: regulator at 1 {\n" + "> >+\t\tsata0_power: regulator@1 {\n" "> >+\t\t\tcompatible = \"regulator-fixed\";\n" "> >+\t\t\treg = <1>;\n" "> >+\t\t\tregulator-name = \"SATA0 Power\";\n" @@ -253,7 +261,7 @@ "> \n" "> >+\t\t};\n" "> >+\n" - "> >+\t\tsata1_power: regulator at 2 {\n" + "> >+\t\tsata1_power: regulator@2 {\n" "> >+\t\t\tcompatible = \"regulator-fixed\";\n" "> >+\t\t\treg = <2>;\n" "> >+\t\t\tregulator-name = \"SATA1 Power\";\n" @@ -276,7 +284,7 @@ "> >+\n" "> >+&mdio {\n" "> >+\tstatus = \"okay\";\n" - "> >+\tethphy0: ethernet-phy at 8 {\n" + "> >+\tethphy0: ethernet-phy@8 {\n" "> >+\t\t reg = <8>;\n" "> >+\t };\n" "> \n" @@ -286,7 +294,7 @@ "> >+\n" "> >+ð0 {\n" "> >+\tstatus = \"okay\";\n" - "> >+\tethernet0-port at 0 {\n" + "> >+\tethernet0-port@0 {\n" "> >+\t\tphy-handle = <ðphy0>;\n" "> >+\t};\n" "> >+};\n" @@ -294,13 +302,17 @@ "> \n" "> Overall, this look fine to me, with the nits taken care of\n" "> \n" - "> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>\n" + "> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" "> \n" "> Thanks!\n" "> \n" "\n" "Thanks,\n" "\n" - evgeni + "evgeni\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -2e275c345b2e66583a454a10996275ec8aae9074a26982ccf091a9415943f1ce +ec8555f084a833a0cc773ac7f22b3eeb4efd1bfb3459e1f8927e1e38691ffeb3
diff --git a/a/1.txt b/N2/1.txt index 3a58b38..b592dc2 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -93,8 +93,8 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ stdout-path = &uart0; > >+ }; > >+ -> >+ ocp at f1000000 { -> >+ pinctrl: pin-controller at 10000 { +> >+ ocp@f1000000 { +> >+ pinctrl: pin-controller@10000 { > > v3.19 should already have a label for the common pinctrl node. > Please do not replay the bus structure but use a node reference @@ -149,7 +149,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > Nice! Can you also clarify if TX/RX are as seen from the SoC or > remote end? > -> >+ serial at 12000 { +> >+ serial@12000 { > > Please use node references where possible, IIRC v3.19 should have > labels for serial, sata, and i2c. Avoid to replay the bus structure. @@ -157,7 +157,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ status = "okay"; > >+ }; > >+ -> >+ sata at 80000 { +> >+ sata@80000 { > >+ status = "okay"; > >+ nr-ports = <2>; > @@ -167,14 +167,14 @@ thank you for your review. I will make the changes you suggest and resubmit. > > >+ }; > >+ -> >+ i2c at 11000 { +> >+ i2c@11000 { > >+ status = "okay"; -> >+ adt7476: adt7476a at 2e { +> >+ adt7476: adt7476a@2e { > > I know we have a lot of bad examples, but: node names should reflect > device function, not device name, i.e. > -> adt7476: thermal at 2e { +> adt7476: thermal@2e { > ... > }; > @@ -194,7 +194,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > > Add a blank line between nodes. > -> >+ button at 1{ +> >+ button@1{ > >+ label = "Reset push button"; > > Reduce label to "Reset" and "Power" below. @@ -202,7 +202,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ linux,code = <KEY_POWER>; > >+ gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>; > >+ }; -> >+ button at 2{ +> >+ button@2{ > >+ label = "Power push button"; > >+ linux,code = <KEY_SLEEP>; > >+ gpios = <&gpio0 26 GPIO_ACTIVE_LOW>; @@ -228,7 +228,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ pinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>; > >+ pinctrl-names = "default"; > >+ -> >+ sata0_power: regulator at 1 { +> >+ sata0_power: regulator@1 { > >+ compatible = "regulator-fixed"; > >+ reg = <1>; > >+ regulator-name = "SATA0 Power"; @@ -244,7 +244,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > > >+ }; > >+ -> >+ sata1_power: regulator at 2 { +> >+ sata1_power: regulator@2 { > >+ compatible = "regulator-fixed"; > >+ reg = <2>; > >+ regulator-name = "SATA1 Power"; @@ -267,7 +267,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ > >+&mdio { > >+ status = "okay"; -> >+ ethphy0: ethernet-phy at 8 { +> >+ ethphy0: ethernet-phy@8 { > >+ reg = <8>; > >+ }; > @@ -277,7 +277,7 @@ thank you for your review. I will make the changes you suggest and resubmit. > >+ > >+ð0 { > >+ status = "okay"; -> >+ ethernet0-port at 0 { +> >+ ethernet0-port@0 { > >+ phy-handle = <ðphy0>; > >+ }; > >+}; diff --git a/a/content_digest b/N2/content_digest index c03a97f..f657e23 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,10 +1,17 @@ "ref\020141215203855.GA28940@anne\0" "ref\020141222125750.GA29163@anne\0" "ref\0549C0C3C.8060601@gmail.com\0" - "From\0evgeni@studio-punkt.com (Evgeni Dobrev)\0" - "Subject\0[PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" + "From\0Evgeni Dobrev <evgeni@studio-punkt.com>\0" + "Subject\0Re: [PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" "Date\0Fri, 26 Dec 2014 12:06:49 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>\0" + "Cc\0devicetree@vger.kernel.org" + linux-kernel@vger.kernel.org + linux-arm-kernel@lists.infradead.org + Jason Cooper <jason@lakedaemon.net> + Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com> + Gregory Clement <gregory.clement@free-electrons.com> + " Andrew Lunn <andrew@lunn.ch>\0" "\00:1\0" "b\0" "Hello Sebastian,\n" @@ -102,8 +109,8 @@ "> >+\t\tstdout-path = &uart0;\n" "> >+\t};\n" "> >+\n" - "> >+\tocp at f1000000 {\n" - "> >+\t\tpinctrl: pin-controller at 10000 {\n" + "> >+\tocp@f1000000 {\n" + "> >+\t\tpinctrl: pin-controller@10000 {\n" "> \n" "> v3.19 should already have a label for the common pinctrl node.\n" "> Please do not replay the bus structure but use a node reference\n" @@ -158,7 +165,7 @@ "> Nice! Can you also clarify if TX/RX are as seen from the SoC or\n" "> remote end?\n" "> \n" - "> >+\t\tserial at 12000 {\n" + "> >+\t\tserial@12000 {\n" "> \n" "> Please use node references where possible, IIRC v3.19 should have\n" "> labels for serial, sata, and i2c. Avoid to replay the bus structure.\n" @@ -166,7 +173,7 @@ "> >+\t\t\tstatus = \"okay\";\n" "> >+\t\t};\n" "> >+\n" - "> >+\t\tsata at 80000 {\n" + "> >+\t\tsata@80000 {\n" "> >+\t\t\tstatus = \"okay\";\n" "> >+\t\t\tnr-ports = <2>;\n" "> \n" @@ -176,14 +183,14 @@ "> \n" "> >+\t\t};\n" "> >+\n" - "> >+\t\ti2c at 11000 {\n" + "> >+\t\ti2c@11000 {\n" "> >+\t\t\tstatus = \"okay\";\n" - "> >+\t\t\tadt7476: adt7476a at 2e {\n" + "> >+\t\t\tadt7476: adt7476a@2e {\n" "> \n" "> I know we have a lot of bad examples, but: node names should reflect\n" "> device function, not device name, i.e.\n" "> \n" - "> adt7476: thermal at 2e {\n" + "> adt7476: thermal@2e {\n" "> \t...\n" "> };\n" "> \n" @@ -203,7 +210,7 @@ "> \n" "> Add a blank line between nodes.\n" "> \n" - "> >+\t\tbutton at 1{\n" + "> >+\t\tbutton@1{\n" "> >+\t\t\tlabel = \"Reset push button\";\n" "> \n" "> Reduce label to \"Reset\" and \"Power\" below.\n" @@ -211,7 +218,7 @@ "> >+\t\t\tlinux,code = <KEY_POWER>;\n" "> >+\t\t\tgpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;\n" "> >+\t\t};\n" - "> >+\t\tbutton at 2{\n" + "> >+\t\tbutton@2{\n" "> >+\t\t\tlabel = \"Power push button\";\n" "> >+\t\t\tlinux,code = <KEY_SLEEP>;\n" "> >+\t\t\tgpios = <&gpio0 26 GPIO_ACTIVE_LOW>;\n" @@ -237,7 +244,7 @@ "> >+\t\tpinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>;\n" "> >+\t\tpinctrl-names = \"default\";\n" "> >+\n" - "> >+\t\tsata0_power: regulator at 1 {\n" + "> >+\t\tsata0_power: regulator@1 {\n" "> >+\t\t\tcompatible = \"regulator-fixed\";\n" "> >+\t\t\treg = <1>;\n" "> >+\t\t\tregulator-name = \"SATA0 Power\";\n" @@ -253,7 +260,7 @@ "> \n" "> >+\t\t};\n" "> >+\n" - "> >+\t\tsata1_power: regulator at 2 {\n" + "> >+\t\tsata1_power: regulator@2 {\n" "> >+\t\t\tcompatible = \"regulator-fixed\";\n" "> >+\t\t\treg = <2>;\n" "> >+\t\t\tregulator-name = \"SATA1 Power\";\n" @@ -276,7 +283,7 @@ "> >+\n" "> >+&mdio {\n" "> >+\tstatus = \"okay\";\n" - "> >+\tethphy0: ethernet-phy at 8 {\n" + "> >+\tethphy0: ethernet-phy@8 {\n" "> >+\t\t reg = <8>;\n" "> >+\t };\n" "> \n" @@ -286,7 +293,7 @@ "> >+\n" "> >+ð0 {\n" "> >+\tstatus = \"okay\";\n" - "> >+\tethernet0-port at 0 {\n" + "> >+\tethernet0-port@0 {\n" "> >+\t\tphy-handle = <ðphy0>;\n" "> >+\t};\n" "> >+};\n" @@ -303,4 +310,4 @@ "\n" evgeni -2e275c345b2e66583a454a10996275ec8aae9074a26982ccf091a9415943f1ce +b37ed98f9c18521d73c740ab13fe2ca0bc40a25705155f7f522b14a1e9398ca5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.