From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] add omap34xx temperature monitoring support Date: Fri, 26 Dec 2014 08:31:16 -0800 Message-ID: <20141226163115.GA2411@atomide.com> References: <20141226102933.GA28778@amd> <20141226155456.GB12409@atomide.com> <20141226161757.GD12409@atomide.com> <201412261726.35668@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <201412261726.35668@pali> Sender: linux-kernel-owner@vger.kernel.org To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Pavel Machek , sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org List-Id: linux-omap@vger.kernel.org * Pali Roh=C3=A1r [141226 08:29]: > On Friday 26 December 2014 17:17:57 Tony Lindgren wrote: > > > > + > > > > +#include "../../arch/arm/mach-omap2/control.h" > > >=20 > > > No need to do this, you can use syscon here like > > > pbias-regulator.c is doing. > >=20 > > Oh looks like you're already using syscon, nice. What defines > > do you need from control.h? > >=20 > > Those should be in the driver if private to the driver, or > > else we should have some minimal header in include/linux > > somewhere if some control.h defines really need to be > > exposed. > >=20 > > Regards, > >=20 > > Tony >=20 > Hi Tony, >=20 > Sebastian Reichel has already sent new version of temperature=20 > driver. See email thread with subject: >=20 > [PATCH 0/3] OMAP3 temperature sensor Yeah great, looks like I was also reading Sebastian's patch with the syscon comments above :) Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Fri, 26 Dec 2014 16:31:16 +0000 Subject: Re: [lm-sensors] [PATCH] add omap34xx temperature monitoring support Message-Id: <20141226163115.GA2411@atomide.com> List-Id: References: <20141226102933.GA28778@amd> <20141226155456.GB12409@atomide.com> <20141226161757.GD12409@atomide.com> <201412261726.35668@pali> In-Reply-To: <201412261726.35668@pali> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Pavel Machek , sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org KiBQYWxpIFJvaMOhciA8cGFsaS5yb2hhckBnbWFpbC5jb20+IFsxNDEyMjYgMDg6MjldOgo+IE9u IEZyaWRheSAyNiBEZWNlbWJlciAyMDE0IDE3OjE3OjU3IFRvbnkgTGluZGdyZW4gd3JvdGU6Cj4g PiA+ID4gKwo+ID4gPiA+ICsjaW5jbHVkZSAiLi4vLi4vYXJjaC9hcm0vbWFjaC1vbWFwMi9jb250 cm9sLmgiCj4gPiA+IAo+ID4gPiBObyBuZWVkIHRvIGRvIHRoaXMsIHlvdSBjYW4gdXNlIHN5c2Nv biBoZXJlIGxpa2UKPiA+ID4gcGJpYXMtcmVndWxhdG9yLmMgaXMgZG9pbmcuCj4gPiAKPiA+IE9o IGxvb2tzIGxpa2UgeW91J3JlIGFscmVhZHkgdXNpbmcgc3lzY29uLCBuaWNlLiBXaGF0IGRlZmlu ZXMKPiA+IGRvIHlvdSBuZWVkIGZyb20gY29udHJvbC5oPwo+ID4gCj4gPiBUaG9zZSBzaG91bGQg YmUgaW4gdGhlIGRyaXZlciBpZiBwcml2YXRlIHRvIHRoZSBkcml2ZXIsIG9yCj4gPiBlbHNlIHdl IHNob3VsZCBoYXZlIHNvbWUgbWluaW1hbCBoZWFkZXIgaW4gaW5jbHVkZS9saW51eAo+ID4gc29t ZXdoZXJlIGlmIHNvbWUgY29udHJvbC5oIGRlZmluZXMgcmVhbGx5IG5lZWQgdG8gYmUKPiA+IGV4 cG9zZWQuCj4gPiAKPiA+IFJlZ2FyZHMsCj4gPiAKPiA+IFRvbnkKPiAKPiBIaSBUb255LAo+IAo+ IFNlYmFzdGlhbiBSZWljaGVsIGhhcyBhbHJlYWR5IHNlbnQgbmV3IHZlcnNpb24gb2YgdGVtcGVy YXR1cmUgCj4gZHJpdmVyLiBTZWUgZW1haWwgdGhyZWFkIHdpdGggc3ViamVjdDoKPiAKPiBbUEFU Q0ggMC8zXSBPTUFQMyB0ZW1wZXJhdHVyZSBzZW5zb3IKClllYWggZ3JlYXQsIGxvb2tzIGxpa2Ug SSB3YXMgYWxzbyByZWFkaW5nIFNlYmFzdGlhbidzIHBhdGNoCndpdGggdGhlIHN5c2NvbiBjb21t ZW50cyBhYm92ZSA6KQoKUmVnYXJkcywKClRvbnkKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNA bG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGlu Zm8vbG0tc2Vuc29ycw= From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 26 Dec 2014 08:31:16 -0800 Subject: [PATCH] add omap34xx temperature monitoring support In-Reply-To: <201412261726.35668@pali> References: <20141226102933.GA28778@amd> <20141226155456.GB12409@atomide.com> <20141226161757.GD12409@atomide.com> <201412261726.35668@pali> Message-ID: <20141226163115.GA2411@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Pali Roh?r [141226 08:29]: > On Friday 26 December 2014 17:17:57 Tony Lindgren wrote: > > > > + > > > > +#include "../../arch/arm/mach-omap2/control.h" > > > > > > No need to do this, you can use syscon here like > > > pbias-regulator.c is doing. > > > > Oh looks like you're already using syscon, nice. What defines > > do you need from control.h? > > > > Those should be in the driver if private to the driver, or > > else we should have some minimal header in include/linux > > somewhere if some control.h defines really need to be > > exposed. > > > > Regards, > > > > Tony > > Hi Tony, > > Sebastian Reichel has already sent new version of temperature > driver. See email thread with subject: > > [PATCH 0/3] OMAP3 temperature sensor Yeah great, looks like I was also reading Sebastian's patch with the syscon comments above :) Regards, Tony