All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/lftp: don't use host's path
Date: Fri, 26 Dec 2014 20:11:43 +0100	[thread overview]
Message-ID: <20141226201143.143896ff@free-electrons.com> (raw)
In-Reply-To: <1419614983-8105-1-git-send-email-romain.naour@openwide.fr>

Dear Romain Naour,

On Fri, 26 Dec 2014 18:29:42 +0100, Romain Naour wrote:
> lftp try to link with -L/usr/lib/lftp/$(LFTP_VERSION) if
> DESTDIR is not set.
> 
> When DESTDIR is set to STAGING_DIR, it link with
> -L$(STAGING_DIR)/usr/lib/lftp/$(LFTP_VERSION)
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/lftp/lftp.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/lftp/lftp.mk b/package/lftp/lftp.mk
> index 1586579..73e3087 100644
> --- a/package/lftp/lftp.mk
> +++ b/package/lftp/lftp.mk
> @@ -45,6 +45,10 @@ LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_FTP) += proto-ftp.so
>  LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_HTTP) += proto-http.so
>  LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_SFTP) += proto-sftp.so
>  
> +# Set DESTDIR to STAGING_DIR during the build to avoid linking
> +# with -L/usr/lib/lftp/$(LFTP_VERSION)
> +LFTP_MAKE_ENV += DESTDIR="$(STAGING_DIR)"

Can we patch lftp's build system instead, and submit the patch upstream?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-12-26 19:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-26 17:29 [Buildroot] [PATCH 1/2] package/lftp: don't use host's path Romain Naour
2014-12-26 17:29 ` [Buildroot] [PATCH 2/2] package/tmux: remove unsafe headers path Romain Naour
2014-12-27 10:27   ` Thomas Petazzoni
2014-12-26 19:11 ` Thomas Petazzoni [this message]
2014-12-26 21:50   ` [Buildroot] [PATCH 1/2] package/lftp: don't use host's path Romain Naour
2014-12-27 10:28     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141226201143.143896ff@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.