From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [RFC] resolve conflict between net/ethernet.h and rte_ethdev.h
Date: Sat, 27 Dec 2014 22:48:52 -0500 [thread overview]
Message-ID: <20141228034852.GA18713@localhost.localdomain> (raw)
In-Reply-To: <20141227151300.7b62f5bf@urahara>
On Sat, Dec 27, 2014 at 03:13:00PM -0800, Stephen Hemminger wrote:
> This is a patch to address the conflict between <net/ethernet.h>
> and the definitions in <rte_ethdev.h>. It has two side effects
> worth discussion:
> 1. It forces inclusion of net/ethernet.h
> 2. It has definition to deal with the differing structure elements
> in the two versions of struct ether_addr.
>
> By doing this ether_ntoa and related functions can be used without
> messing with prototypes.
>
> Alternative is more complex #ifdef magic like linux/libc-compat.h
>
>
This seems like a reasonable fix for the problem, and nasty compat-work
Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
next prev parent reply other threads:[~2014-12-28 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 23:13 [RFC] resolve conflict between net/ethernet.h and rte_ethdev.h Stephen Hemminger
2014-12-28 3:48 ` Neil Horman [this message]
2015-01-06 10:44 ` Thomas Monjalon
2015-03-04 23:16 ` Thomas Monjalon
2015-03-10 13:29 ` Thomas Monjalon
2015-03-10 15:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141228034852.GA18713@localhost.localdomain \
--to=nhorman-2xusbdqka4r54taoqtywwq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.