From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Jonas Lundqvist <jonas@gannon.se>
Cc: Jeremiah Mahler <jmmahler@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: line6: remove spaces before commas.
Date: Mon, 29 Dec 2014 12:32:39 +0530 [thread overview]
Message-ID: <20141229070239.GC3749@sudip-PC> (raw)
In-Reply-To: <54A06874.7050006@gannon.se>
On Sun, Dec 28, 2014 at 09:30:44PM +0100, Jonas Lundqvist wrote:
> Hi Jeremiah,
>
> On 12/28/2014 04:44 PM, Jeremiah Mahler wrote:
> > Jonas,
> >
> > On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote:
> >> Fixed three errors in pcm.h found by checkpatch.pl.
> >
> > What type of errors did you fix?
>
> These errors:
> drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
> (ctx:WxE)
I am sure Jeremiah Mahler actually wanted to tell you that you should include that information in the commit log. We always mention what kind of error was fixed.
thanks
sudip
>
>
> BR
> Jonas
>
next prev parent reply other threads:[~2014-12-29 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 13:26 [PATCH] Staging: line6: remove spaces before commas Jonas Lundqvist
2014-12-28 15:44 ` Jeremiah Mahler
2014-12-28 20:30 ` Jonas Lundqvist
2014-12-29 7:02 ` Sudip Mukherjee [this message]
2014-12-29 15:34 ` Jonas Lundqvist
2014-12-29 17:41 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229070239.GC3749@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmmahler@gmail.com \
--cc=jonas@gannon.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.