From: Joe MacDonald <Joe_MacDonald@mentor.com>
To: leimaohui <leimaohui@cn.fujitsu.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH 0/2] add new recipes for GeoIP
Date: Mon, 29 Dec 2014 15:22:56 -0500 [thread overview]
Message-ID: <20141229202255.GG4672@mentor.com> (raw)
In-Reply-To: <1419575006-51771-1-git-send-email-leimaohui@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 2308 bytes --]
[[oe] [meta-networking][PATCH 0/2] add new recipes for GeoIP] On 14.12.26 (Fri 14:23) leimaohui wrote:
> GeoIP: allow you to look up information about a given IP address.
> geoipupdate: can download and update the GeoLite Legacy databases.
This looks good over-all but we're really trying to limit the number of
.inc files unless we have an expectation that we'll be maintaining more
than one version of the recipe at the same time. Or, I suppose, if the
recipe is very complex and it could be made clearer by breaking it up
into an include and a recipe file, that might make sense, but I don't
think this falls into either category. Would you mind combining them
and eliminating the .inc file?
While we're here, there's a couple of minor stylistic things. I don't
know exactly what's happening here:
meta-networking/recipes-support/GeoIP/GeoIP_1.6.0.bb:
51 PACKAGES =+ "${PN}-database"
52 FILES_${PN}-database = ""
53 FILES_${PN}-database += "${datadir}/GeoIP/*"
and for this:
28 LIC_FILES_CHKSUM = "\
29 file://COPYING;md5=d5d53d6b948c064f4070183180a4fa89 \
30 file://LICENSE;md5=f04db71812ba70aaba8b38da91984cd2 \
31 "
the usual approach is to either line up the indenting with the first "
or four spaces. I'm okay with either, though four spaces is probably
preferred here and probably do the same for EXTRA_OECONF.
-J.
>
> leimh (2):
> GeoIP: add recipe
> geoipupdate: add new recipe
>
> meta-networking/recipes-support/GeoIP/GeoIP.inc | 10 ++++
> .../recipes-support/GeoIP/GeoIP_1.6.0.bb | 54 ++++++++++++++++++++++
> .../GeoIP/geoipupdate-2.1.0/GeoIP.conf | 11 +++++
> .../GeoIP/geoipupdate-2.1.0/geoipupdate.cron | 5 ++
> .../recipes-support/GeoIP/geoipupdate_2.1.0.bb | 26 +++++++++++
> 5 files changed, 106 insertions(+)
> create mode 100644 meta-networking/recipes-support/GeoIP/GeoIP.inc
> create mode 100644 meta-networking/recipes-support/GeoIP/GeoIP_1.6.0.bb
> create mode 100644 meta-networking/recipes-support/GeoIP/geoipupdate-2.1.0/GeoIP.conf
> create mode 100644 meta-networking/recipes-support/GeoIP/geoipupdate-2.1.0/geoipupdate.cron
> create mode 100644 meta-networking/recipes-support/GeoIP/geoipupdate_2.1.0.bb
>
> --
> 1.9.1
>
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]
next prev parent reply other threads:[~2014-12-29 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 6:23 [meta-networking][PATCH 0/2] add new recipes for GeoIP leimaohui
2014-12-26 6:23 ` [meta-networking][PATCH 1/2] GeoIP: add recipe leimaohui
2014-12-30 8:27 ` Martin Jansa
2015-01-02 11:18 ` Lei, Maohui
2014-12-26 6:23 ` [meta-networking][PATCH 2/2] geoipupdate: add new recipe leimaohui
2014-12-29 20:22 ` Joe MacDonald [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-05 2:39 [meta-networking][PATCH 0/2] add new recipes for GeoIP leimaohui
2015-01-07 19:13 ` Joe MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229202255.GG4672@mentor.com \
--to=joe_macdonald@mentor.com \
--cc=leimaohui@cn.fujitsu.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.