From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, b50113@freescale.com
Subject: Re: [RFC] ASoC: wm8962: Allow codec to work when CONFIG_PM=n
Date: Tue, 30 Dec 2014 16:22:03 +0000 [thread overview]
Message-ID: <20141230162203.GF17800@sirena.org.uk> (raw)
In-Reply-To: <1419955096-18810-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]
On Tue, Dec 30, 2014 at 01:58:16PM -0200, Fabio Estevam wrote:
> + if (!IS_ENABLED(CONFIG_PM))
> + wm8962_runtime_resume(&i2c->dev);
> +
A much neater idiom for this is to have the probe() just default the
device to being runtime PM enabled, then if runtime PM is enabled it'll
work out that the device is idle and power it off but if runtime PM is
disabled it'll just stay powered.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-12-30 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 15:58 [RFC] ASoC: wm8962: Allow codec to work when CONFIG_PM=n Fabio Estevam
2014-12-30 16:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230162203.GF17800@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=b50113@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.