From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] imx: i2c: Zap unnecessary malloc() calls
Date: Tue, 30 Dec 2014 16:34:02 +0100 [thread overview]
Message-ID: <201412301634.02793.marex@denx.de> (raw)
In-Reply-To: <54A2A9F7.7000007@denx.de>
On Tuesday, December 30, 2014 at 02:34:47 PM, Stefano Babic wrote:
> On 16/12/2014 14:09, Marek Vasut wrote:
> > The malloc() calls are unnecessary, just allocate the stuff on stack.
> > While at it, reorder the code a little, so that only one variable is
> > used for the text, use snprintf() instead of sprintf() and use %01d
> > as a formatting string to avoid any possible overflows.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Igor Grinberg <grinberg@compulab.co.il>
> > Cc: Nikita Kiryanov <nikita@compulab.co.il>
> > Cc: Sean Cross <xobs@kosagi.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Tim Harvey <tharvey@gateworks.com>
> > ---
>
> Applied to u-boot-imx, thanks !
Hey!
hope you had a nice holiday :) You might want to apply 2/8 and 3/8 to current
codebase and send it to Tom, since they fix real problem and the board doesn't
boot without this. I should have separated them out, sorry.
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-12-30 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 13:09 [U-Boot] [PATCH 1/8] imx: i2c: Zap unnecessary malloc() calls Marek Vasut
2014-12-16 13:09 ` [U-Boot] [PATCH 2/8] arm: mx6: gw_ventana: Define CONFIG_SYS_MALLOC_F_LEN Marek Vasut
2014-12-30 13:35 ` Stefano Babic
2014-12-16 13:09 ` [U-Boot] [PATCH 3/8] arm: mx6: novena: " Marek Vasut
2014-12-30 13:35 ` Stefano Babic
2014-12-16 13:09 ` [U-Boot] [PATCH 4/8] arm: mx6: novena: Minor coding style fix Marek Vasut
2014-12-30 13:35 ` Stefano Babic
2014-12-16 13:09 ` [U-Boot] [PATCH 5/8] arm: mx6: novena: Minor config file fix Marek Vasut
2014-12-30 13:35 ` Stefano Babic
2014-12-16 13:09 ` [U-Boot] [PATCH 6/8] arm: mx6: novena: Pull GPIO definitions into header Marek Vasut
2014-12-30 13:35 ` Stefano Babic
2014-12-16 13:09 ` [U-Boot] [PATCH 7/8] arm: mx6: novena: Pull video handling into separate file Marek Vasut
2014-12-30 13:36 ` Stefano Babic
2014-12-16 13:09 ` [U-Boot] [PATCH 8/8] arm: mx6: novena: Add proper LVDS display support Marek Vasut
2014-12-16 16:22 ` Simon Glass
2014-12-16 16:59 ` Marek Vasut
2014-12-30 13:37 ` Stefano Babic
2014-12-16 15:34 ` [U-Boot] [PATCH 1/8] imx: i2c: Zap unnecessary malloc() calls Christian Gmeiner
2014-12-16 16:27 ` Simon Glass
2014-12-16 17:00 ` Marek Vasut
2014-12-30 13:34 ` Stefano Babic
2014-12-30 15:34 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412301634.02793.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.