All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serguey Parkhomovsky <sergueyparkhomovsky@gmail.com>
To: Jeremiah Mahler <jmmahler@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration
Date: Tue, 30 Dec 2014 19:04:35 -0800	[thread overview]
Message-ID: <20141231030435.GA3775@fedora.localdomain> (raw)
In-Reply-To: <20141230223518.GA31616@hudson.localdomain>

On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
> 
> If you look at the source code just below these functions you will find:
> 
> EXPORT_SYMBOL(libcfs_arch_init);
> EXPORT_SYMBOL(libcfs_arch_cleanup);
> 
> So making these static is incorrect because they are being used outside
> of this file.
> 

Thanks for the review, and sorry about the noise; I'll be more careful next time.

Serguey

  reply	other threads:[~2014-12-31  3:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 11:10 [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration Serguey Parkhomovsky
2014-12-30 22:35 ` Jeremiah Mahler
2014-12-31  3:04   ` Serguey Parkhomovsky [this message]
2014-12-31  5:20     ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141231030435.GA3775@fedora.localdomain \
    --to=sergueyparkhomovsky@gmail.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmmahler@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.