From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/7] Adding ding-libs
Date: Wed, 31 Dec 2014 18:03:14 +0100 [thread overview]
Message-ID: <20141231180314.79697bfd@free-electrons.com> (raw)
In-Reply-To: <1418398967-2183-2-git-send-email-gregd72002@gmail.com>
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:41 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/ding-libs/Config.in | 9 +++++++++
> package/ding-libs/ding-libs.hash | 1 +
> package/ding-libs/ding-libs.mk | 17 +++++++++++++++++
> 4 files changed, 28 insertions(+)
> create mode 100644 package/ding-libs/Config.in
> create mode 100644 package/ding-libs/ding-libs.hash
> create mode 100644 package/ding-libs/ding-libs.mk
Thanks, applied, after doing again a fairly significant amount of fixes:
[Thomas:
- Remove unneeded comment in Config.in
- Remove select if libiconv, not needed
- Add dependency on wchar, needed when we depend on gettext
- Improve Config.in help text
- Fix the format of the hash file to make it actually useful
- Fix the comment header in the .mk file
- Remove useless commented line in .mk file
- Fixup license information: it's not under GPLv3, but under LGPLv3+
(library) and GPLv3+ (test programs)
- Add host-pkgconf to the dependencies, remove libiconv from the
dependencies.
- Add a comment to explain why autoreconf is needed.
- Remove usage of $(MAKE1) that does look necessary.]
See
http://git.buildroot.net/buildroot/commit/?id=3af1d306bdc4144e243e453221a7ab5a49b14e56
for the final commit.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-12-31 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
2014-12-12 15:42 ` [Buildroot] [PATCH v2 1/7] Adding ding-libs Gregory Dymarek
2014-12-31 17:03 ` Thomas Petazzoni [this message]
2014-12-12 15:42 ` [Buildroot] [PATCH v2 2/7] Adding gengetopt Gregory Dymarek
2015-01-01 14:07 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 3/7] Adding libnice Gregory Dymarek
2014-12-31 16:05 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 4/7] Adding libsrtp Gregory Dymarek
2015-01-01 10:30 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 5/7] Adding libwebsock Gregory Dymarek
2015-01-01 11:43 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 6/7] Adding sofia-sip Gregory Dymarek
2015-01-01 13:52 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 7/7] Adding janus-gateway Gregory Dymarek
2015-01-01 15:46 ` Thomas Petazzoni
2014-12-12 15:58 ` [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Vicente Olivert Riera
2014-12-12 16:06 ` Gregory Dymarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141231180314.79697bfd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.