All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serguey Parkhomovsky <sergueyparkhomovsky@gmail.com>
To: Konrad Zapalowicz <bergo.torino@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration
Date: Wed, 31 Dec 2014 10:55:17 -0800	[thread overview]
Message-ID: <20141231185517.GA899@fedora.localdomain> (raw)
In-Reply-To: <20141231104029.GA25819@t400>

On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote:
> This lines are way too long. You should break the commit message line
> around 72nd column so that it looks nice when emailed.
> 
> You can also omit the filename from the topic line as this is already in
> the diff.

Thanks for the feedback; I'll send an updated patch that fixes these issues.

Serguey

      reply	other threads:[~2014-12-31 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-31  8:48 [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration Serguey Parkhomovsky
2014-12-31 10:40 ` Konrad Zapalowicz
2014-12-31 18:55   ` Serguey Parkhomovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141231185517.GA899@fedora.localdomain \
    --to=sergueyparkhomovsky@gmail.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=bergo.torino@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.