Re: [PATCH] arch: mips: pci: pci-ip27.c: Remove unused function

[Paul Gortmaker <paul.gortmaker@windriver.com>]

[[PATCH] arch: mips: pci: pci-ip27.c:  Remove unused function] On 01/01/2015 (Thu 16:32) Rickard Strandqvist wrote:

> Remove the function pci_enable_swapping() that is not used anywhere.

A quick search shows it has been orphanware since the git epoch (~2005)
so removing it should be fine AFAICT.

P.
--

> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  arch/mips/pci/pci-ip27.c |   11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/arch/mips/pci/pci-ip27.c b/arch/mips/pci/pci-ip27.c
> index 0f09eaf..55e3332 100644
> --- a/arch/mips/pci/pci-ip27.c
> +++ b/arch/mips/pci/pci-ip27.c
> @@ -200,17 +200,6 @@ static inline void pci_disable_swapping(struct pci_dev *dev)
>  	bridge->b_widget.w_tflush;	/* Flush */
>  }
>  
> -static inline void pci_enable_swapping(struct pci_dev *dev)
> -{
> -	struct bridge_controller *bc = BRIDGE_CONTROLLER(dev->bus);
> -	bridge_t *bridge = bc->base;
> -	int slot = PCI_SLOT(dev->devfn);
> -
> -	/* Turn on byte swapping */
> -	bridge->b_device[slot].reg |= BRIDGE_DEV_SWAP_DIR;
> -	bridge->b_widget.w_tflush;	/* Flush */
> -}
> -
>  static void pci_fixup_ioc3(struct pci_dev *d)
>  {
>  	pci_disable_swapping(d);
> -- 
> 1.7.10.4
>