From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 2/4] pkg-download: silence check-hash if it is a silent build
Date: Thu, 1 Jan 2015 17:24:55 +0100 [thread overview]
Message-ID: <20150101162455.GC4360@free.fr> (raw)
In-Reply-To: <1419947920-22047-3-git-send-email-fabio.porcedda@gmail.com>
Fabio, All,
On 2014-12-30 14:58 +0100, Fabio Porcedda spake thusly:
> If it is a silent build (make -s -> QUIET=-q) silence the "check-hash"
> script.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Even though I acked it earlier, I missed something...
Sorry... :-(
> diff --git a/support/download/check-hash b/support/download/check-hash
> index b59fd2a..82f2e65 100755
> --- a/support/download/check-hash
> +++ b/support/download/check-hash
> @@ -10,6 +13,19 @@ set -e
> # saved as, to be able to match it to the corresponding hashes
> # in the .hash file
>
> +quiet=
> +while getopts "q" opt; do
> + case $opt in
> + q)
> + quiet=-q
> + ;;
> + \?)
> + exit 1
> + ;;
> + esac
This script does not use TABs, so do not introduce any.
> +done
> +shift $((OPTIND-1))
> +
> h_file="${1}"
> file="${2}"
> base="${3}"
> @@ -43,7 +59,9 @@ check_one_hash() {
> # Do the hashes match?
> _hash=$( ${_h}sum "${_file}" |cut -d ' ' -f 1 )
> if [ "${_hash}" = "${_known}" ]; then
> - printf "%s: OK (%s: %s)\n" "${base}" "${_h}" "${_hash}"
> + if [ -z "${quiet}" ]; then
> + printf "%s: OK (%s: %s)\n" "${base}" "${_h}" "${_hash}"
> + fi
Ditto, do not introduce TABs.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-01 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 13:58 [Buildroot] [PATCH v7 0/4] Improve silent builds Fabio Porcedda
2014-12-30 13:58 ` [Buildroot] [PATCH v7 1/4] Makefile: improve detection of make "-s" flag Fabio Porcedda
2015-01-01 16:03 ` Yann E. MORIN
2014-12-30 13:58 ` [Buildroot] [PATCH v7 2/4] pkg-download: silence check-hash if it is a silent build Fabio Porcedda
2015-01-01 16:16 ` Yann E. MORIN
2015-01-01 16:24 ` Yann E. MORIN [this message]
2014-12-30 13:58 ` [Buildroot] [PATCH v7 3/4] support/download: silence svn " Fabio Porcedda
2014-12-30 13:58 ` [Buildroot] [PATCH v7 4/4] support/download: silence git " Fabio Porcedda
2015-01-01 16:52 ` [Buildroot] [PATCH v7 0/4] Improve silent builds Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101162455.GC4360@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.