All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/7] linux: add option to rely on a bootloader-provided DTB
Date: Thu, 1 Jan 2015 22:51:02 +0100	[thread overview]
Message-ID: <20150101225102.64944ac5@free-electrons.com> (raw)
In-Reply-To: <20150101214435.GJ4360@free.fr>

Dear Yann E. MORIN,

On Thu, 1 Jan 2015 22:44:35 +0100, Yann E. MORIN wrote:

> Fact is, the prompt reads:
> 
>     [*] Device tree support
> 
> So, I take that as "build a kernel with support for the device tree",
> not as "build a DTB".

Right, the prompt may not be the most appropriate one.

> But Now I think of it, this patch is doing two things:
> 
>   - enable USE_OF when that option is enabled,
> 
>   - add support for bootloader- or board-provided DTB.
> 
> Maybe that should be split up in two, then?
> 
> Or do you still want that option to mean "build a DTB" ?

Yes, I believe the prompt should be changed. I really don't see the
point of adding a new entry in the choice to simply mean "do nothing".

And also, enabling CONFIG_OF should be done by the defconfig of the
platform, not by Buildroot.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-01-01 21:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01 20:23 [Buildroot] [PATCH 0/7] RPi: enable building a device-tree-enabled kernel (branch yem/rpi-dt) Yann E. MORIN
2015-01-01 20:23 ` [Buildroot] [PATCH 1/7] package/rpi-firmware: bump version Yann E. MORIN
2015-01-01 21:25   ` Thomas Petazzoni
2015-01-01 20:23 ` [Buildroot] [PATCH 2/7] linux: add option to rely on a bootloader-provided DTB Yann E. MORIN
2015-01-01 21:24   ` Thomas Petazzoni
2015-01-01 21:44     ` Yann E. MORIN
2015-01-01 21:51       ` Thomas Petazzoni [this message]
2015-01-01 21:58         ` Yann E. MORIN
2015-01-01 22:17           ` Thomas Petazzoni
2015-01-01 22:26             ` Yann E. MORIN
2015-01-01 23:15             ` Peter Korsgaard
2015-01-01 23:21               ` Yann E. MORIN
2015-01-01 20:23 ` [Buildroot] [PATCH 3/7] docs/manual: document LIBFOO_INSTALL_IMAGES Yann E. MORIN
2015-01-01 21:28   ` Thomas Petazzoni
2015-01-01 20:23 ` [Buildroot] [PATCH 4/7] package/rpi-firmware: only install images Yann E. MORIN
2015-01-01 21:58   ` Thomas Petazzoni
2015-01-01 20:23 ` [Buildroot] [PATCH 5/7] package/rpi-firmware: add DT-aware marking script Yann E. MORIN
2015-01-01 20:23 ` [Buildroot] [PATCH 6/7] package/rpi-firmware: install DTB blobs Yann E. MORIN
2015-01-01 20:23 ` [Buildroot] [PATCH 7/7] package/rpi-firmware: append the DTOK footer for DT-aware kernel Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150101225102.64944ac5@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.