All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] Added mpd-mpc, mpc client to mpd
Date: Fri, 2 Jan 2015 17:16:29 +0100	[thread overview]
Message-ID: <20150102171629.44662fe1@free-electrons.com> (raw)
In-Reply-To: <1418419480-7570-1-git-send-email-tbultel@free.fr>

Dear Thierry Bultel,

On Fri, 12 Dec 2014 22:24:39 +0100, Thierry Bultel wrote:
> ---
> 
> Changes v2 -> v3
>   - dependency to host-pkgconf (noticed by J?rg Krause)
>   - optional dependency to libiconv
>   - configure environnement for C99 compiler
> 
> Changes v1 -> v2
>   - No needed dependency to mpd (suggested by Thomas)
>   - Added hash and license information
> 
> Signed-off-by: Thierry Bultel <tbultel@free.fr>

Committed, thanks, with a few changes:

[Thomas:
 - Changed hash file to use SHA256
 - Remove libiconv handling, since the iconv detection in mpc is
   broken: if it's not available in the C library, it expects to find
   iconv() in libintl (from gettext). But it's actually libiconv that
   provides iconv() for non-locale capable uClibc toolchains. But
   since anyway the package builds fine without iconv() support and
   properly detects when it's available, don't bother with this.]

If you can report to upstream the libiconv detection problem, it would
be good.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-01-02 16:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 21:24 [Buildroot] [PATCH v3 1/2] Added mpd-mpc, mpc client to mpd Thierry Bultel
2014-12-12 21:24 ` [Buildroot] [PATCH v3 2/2] mpd: group client and libraries under the same menu Thierry Bultel
2014-12-12 23:55   ` Jörg Krause
2014-12-13  6:42     ` Thierry Bultel
2015-01-10 16:53   ` Thomas Petazzoni
2014-12-12 23:38 ` [Buildroot] [PATCH v3 1/2] Added mpd-mpc, mpc client to mpd Jörg Krause
2015-01-02 16:16 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150102171629.44662fe1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.