Re: [meta-oe][PATCH 03/11] php: integrate modphp

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

On Fri, Jan 02, 2015 at 05:10:34PM +0000, Paul Eggleton wrote:
> Martin Jansa <martin.jansa <at> gmail.com> writes:
> > On Fri, Jan 02, 2015 at 09:31:58AM +0000, Paul Eggleton wrote:
> > > Build the mod-php Apache module within the main php recipe; this avoids
> > > files in the sysroot from stepping on eachother and therefore avoids the
> > > resulting build failure.
> > > 
> > > Changes made:
> > > * Add an "apache2" PACKAGECONFIG, default enabled. This does mean that
> > >   apache2 is a build dependency by default; if you don't want this,
> > >   set your own PACKAGECONFIG value for the php recipe.
> > 
> > I think it should be disabled by default, because meta-oe layer doesn't
> > depend on meta-webserver layer where apache2 lives.
> 
> You're right, somehow I completely missed that - sorry. I'll fix in v2 on
> Monday.
>  
> > meta-webserver can have .bbappend which will add it to PACKAGECONFIG for
> > xdebug to work with default php recipe.
> 
> As you may recall I'm of the opinion that software layers should not be
> setting the policy of other layers, so I don't think this is really
> appropriate; I'll just have to live with the fact that users who want it
> will need to enable it themselves. In any case by the end of the patchset,
> xdebug depends on php rather than modphp so it should still build fine
> without apache2 in PACKAGECONFIG.

Ah, ok, I was assuming that xdebug depends on php with apache2
PACKAGECONFIG enabled.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]