From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-parisc <linux-parisc@vger.kernel.org>,
linux-serial@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH] serial: fix parisc boot hang
Date: Fri, 2 Jan 2015 10:51:27 -0800 [thread overview]
Message-ID: <20150102185127.GA8636@kroah.com> (raw)
In-Reply-To: <1420221913.2072.7.camel@HansenPartnership.com>
On Fri, Jan 02, 2015 at 10:05:13AM -0800, James Bottomley wrote:
> From: James Bottomley <JBottomley@Parallels.com>
>
> This is a partial revert of 2f2dafe (serial: serial_core.c: printk
> replacement) which gets us booting again. The real problem seems to be
> the _emit path in early boot. However, until we can root cause it, we
> need at least to get boot working.
>
> Fixes: 2f2dafe77df2c78e189a9fa6b1879dffd06ae5a1
> Cc: stable@vger.kernel.org
> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
>
> ---
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 57ca61b..984605b 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2164,7 +2164,9 @@ uart_report_port(struct uart_driver *drv, struct uart_port *port)
> break;
> }
>
> - dev_info(port->dev, "%s%d at %s (irq = %d, base_baud = %d) is a %s\n",
> + printk(KERN_INFO "%s%s%s%d at %s (irq = %d, base_baud = %d) is a %s\n",
> + port->dev ? dev_name(port->dev) : "",
> + port->dev ? ": " : "",
> drv->dev_name,
> drv->tty_driver->name_base + port->line,
> address, port->irq, port->uartclk / 16, uart_type(port));
Very odd, but I'll go queue it up, thanks.
greg k-h
next prev parent reply other threads:[~2015-01-02 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 18:05 [PATCH] serial: fix parisc boot hang James Bottomley
2015-01-02 18:51 ` Greg Kroah-Hartman [this message]
2015-01-04 19:12 ` James Bottomley
2015-01-04 20:41 ` John David Anglin
2015-01-05 6:34 ` James Bottomley
2015-01-05 16:02 ` Peter Hurley
2015-01-05 16:51 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102185127.GA8636@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.