From: maximilian attems <max@stro.at>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Thorsten Glaser <tg@debian.org>,
Alexander Wirt <formorer@debian.org>,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org
Subject: Re: [RFC] builddeb: Try to determine distribution
Date: Fri, 2 Jan 2015 12:21:52 -0800 [thread overview]
Message-ID: <20150102202151.GA3519@gluino> (raw)
In-Reply-To: <1420229669-5550-1-git-send-email-sedat.dilek@gmail.com>
On Fri, Jan 02, 2015 at 09:14:29PM +0100, Sedat Dilek wrote:
> This is based on ideas of me and Ben.
> Thanks goes to Thorsten and Alexander for the vital help in 2012.
>
> Like in my initial patch [1] lsb_release is used to determine
> the short codename as distribution name for debian/changelog.
In contrast to the code snippet from Ben, you assume lsb_release
to be installed, which is a wrong assumption.
> Ben gave some helpful and detailed information in [2].
> There he also suggested to have an option to explicitly set the
> distribution (see $KDEB_CHANGELOG_DIST variable).
>
> I have hardcoded the script-name when the default distribution
> is used. This is a bit ugly.
>
> This patch is based on the snippet of Ben in [2] and tested
> against Linux v3.19-rc2.
>
> [1] https://lkml.org/lkml/2012/4/23/516
> [2] http://marc.info/?l=linux-kbuild&m=142022188322321&w=2
>
next prev parent reply other threads:[~2015-01-02 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 20:14 [RFC] builddeb: Try to determine distribution Sedat Dilek
2015-01-02 20:21 ` maximilian attems [this message]
2015-01-02 20:29 ` Sedat Dilek
2015-01-02 20:24 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102202151.GA3519@gluino \
--to=max@stro.at \
--cc=ben@decadent.org.uk \
--cc=formorer@debian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sedat.dilek@gmail.com \
--cc=tg@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.