From: Stephen Hemminger <stephen@networkplumber.org>
To: Vadim Kochan <vadim4j@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 3/3] ss: Filtering logic changing, with fixes
Date: Sat, 3 Jan 2015 09:57:07 -0800 [thread overview]
Message-ID: <20150103095707.37e69147@urahara> (raw)
In-Reply-To: <1420245877-11763-4-git-send-email-vadim4j@gmail.com>
On Sat, 3 Jan 2015 02:44:37 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> +struct filter default_dbs[MAX_DB] = {
> + [TCP_DB] = {
> + .states = SS_CONN,
> + .families = (1 << AF_INET) | (1 << AF_INET6),
> + },
I like table driven code, so this is good. But please make
mark the table as const.
next prev parent reply other threads:[~2015-01-03 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 0:44 [PATCH iproute2 0/3] ss: Fix sockets filtering Vadim Kochan
2015-01-03 0:44 ` [PATCH iproute2 1/3] ss: Unify unix stats output from netlink and proc Vadim Kochan
2015-01-03 17:56 ` Stephen Hemminger
2015-01-03 0:44 ` [PATCH iproute2 2/3] ss: Unify packet " Vadim Kochan
2015-01-03 0:44 ` [PATCH iproute2 3/3] ss: Filtering logic changing, with fixes Vadim Kochan
2015-01-03 17:57 ` Stephen Hemminger [this message]
2015-01-03 22:58 ` Vadim Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150103095707.37e69147@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.