From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbbADB1V (ORCPT ); Sat, 3 Jan 2015 20:27:21 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:43045 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbbADB1S (ORCPT ); Sat, 3 Jan 2015 20:27:18 -0500 Date: Sun, 4 Jan 2015 02:27:13 +0100 From: Konrad Zapalowicz To: Ning Zhou Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, monamagarwal123@gmail.com, gulsah.1004@gmail.com, daniel.dy.ngu@gmail.com, dh.herrmann@gmail.com, josh@joshtriplett.org, linux-kernel@vger.kernel.org, teg@jklm.no, sjw0410@gmail.com, dilekuzulmez@gmail.com, davem@davemloft.net Subject: Re: [PATCH] staging: gdm724x: fix coding style issues Message-ID: <20150104012713.GD25819@t400> References: <1420301035-29052-1-git-send-email-zhou.ning.gd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1420301035-29052-1-git-send-email-zhou.ning.gd@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03, Ning Zhou wrote: > Signed-off-by: Ning Zhou You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two. thanks, konrad > --- > drivers/staging/gdm724x/gdm_lte.c | 3 ++- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c > index 73eede1..7c4a77b 100644 > --- a/drivers/staging/gdm724x/gdm_lte.c > +++ b/drivers/staging/gdm724x/gdm_lte.c > @@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type) > icmp6_out.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT; > icmp6_out.icmp6_code = 0; > icmp6_out.icmp6_cksum = 0; > - icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); /* R=0, S=1, O=1 */ > + /* R=0, S=1, O=1 */ > + icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); > > ns = (struct neighbour_solicitation *) > (skb_in->data + mac_header_len + > diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c > index b5b063a..d1ab996 100644 > --- a/drivers/staging/gdm724x/gdm_mux.c > +++ b/drivers/staging/gdm724x/gdm_mux.c > @@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r) > static void do_rx(struct work_struct *work) > { > struct mux_dev *mux_dev = > - container_of(work, struct mux_dev , work_rx.work); > + container_of(work, struct mux_dev, work_rx.work); > struct mux_rx *r; > struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx; > unsigned long flags; > -- > 1.9.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel