From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linux Input <linux-input@vger.kernel.org>,
Alexander Stein <alexander.stein@systec-electronic.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexander Shiyan <shc_work@mail.ru>,
Laxman Dewangan <ldewangan@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Input: gpio_keys - allow separating gpio and irq in device tree
Date: Sun, 4 Jan 2015 14:27:43 -0800 [thread overview]
Message-ID: <20150104222743.GA31987@dtor-ws> (raw)
In-Reply-To: <CACRpkdZ3PHGRG400Y9zo9RKGyyFm9qF7rZZa8PGpT6AStjUhYA@mail.gmail.com>
On Wed, Dec 31, 2014 at 09:22:27AM +0100, Linus Walleij wrote:
> On Mon, Dec 8, 2014 at 8:19 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > This change allows specify interrupt for buttons separately form gpio,
> > potentially allowing to form several "clusters" of buttons on
> > different interrupts.
> >
> > Button defined without both gpio and irq in device tree is a hared error
>
> hared?
Should have been "hard", sorry...
>
> > instead of a warning now.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> ...but it would be nice if it could also be converted to use GPIO
> descriptors internally at some point.
Thanks.
--
Dmitry
prev parent reply other threads:[~2015-01-04 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 7:19 [PATCH 1/2] Input: gpio_keys - allow separating gpio and irq in device tree Dmitry Torokhov
2014-12-08 7:19 ` Dmitry Torokhov
2014-12-08 7:21 ` [PATCH 2/2] Input: gpio_keys - replace timer and workqueue with delayed workqueue Dmitry Torokhov
2014-12-10 18:32 ` Andy Shevchenko
2014-12-13 19:09 ` Dmitry Torokhov
2014-12-15 10:20 ` Andy Shevchenko
2014-12-14 9:05 ` Linus Walleij
2014-12-31 8:22 ` [PATCH 1/2] Input: gpio_keys - allow separating gpio and irq in device tree Linus Walleij
2015-01-04 22:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104222743.GA31987@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alexander.stein@systec-electronic.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.