From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 06/17] erlang-lager: new package.
Date: Mon, 5 Jan 2015 17:38:53 +0100 [thread overview]
Message-ID: <20150105173853.208d1884@free-electrons.com> (raw)
In-Reply-To: <CAJtjsKZUp=pPN+QFDckg1eKwNdFjiy-LXTNJmxx92O530-1Aog@mail.gmail.com>
Dear Johan Oudinet,
On Mon, 5 Jan 2015 17:10:32 +0100, Johan Oudinet wrote:
> Thomas, All,
>
> On Sun, Jan 4, 2015 at 10:37 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > On Tue, 9 Dec 2014 15:34:11 +0100, Johan Oudinet wrote:
> >
> >> diff --git a/package/erlang-lager/erlang-lager.mk b/package/erlang-lager/erlang-lager.mk
> >> new file mode 100644
> >> index 0000000..b530c8e
> >> --- /dev/null
> >> +++ b/package/erlang-lager/erlang-lager.mk
> >> @@ -0,0 +1,14 @@
> >> +$(eval $(rebar-package))
> >> +$(eval $(host-rebar-package))
> >
> > Same as previous package: why a host variant is needed?
>
> host-erlang-lager is listed in ejabberd dependencies. I do not
> remember why, so I'm going to check if it is really needed and add an
> explanation on the commit message if so.
Ah, my review did not go all the way to ejabberd, sorry about missing
this. Indeed, please check if host-erlang-lager is needed, and if it
is, quickly indicate in the commit log which package uses it.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-05 16:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 14:34 [Buildroot] [PATCH v4 00/17] ejabberd: XMPP server Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 01/17] package/erlang: export EI_VSN so other packages can use it Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 02/17] package/erlang-rebar: new host package Johan Oudinet
2014-12-22 14:16 ` Thomas Petazzoni
2014-12-09 14:34 ` [Buildroot] [PATCH v4 03/17] package/pkg-rebar: new infrastructure Johan Oudinet
2015-01-04 21:23 ` Thomas Petazzoni
2015-01-04 22:20 ` Yann E. MORIN
2015-01-05 9:31 ` Thomas Petazzoni
2015-01-05 11:13 ` Johan Oudinet
2015-01-05 22:01 ` Yann E. MORIN
2015-01-05 21:59 ` Yann E. MORIN
2015-01-06 8:24 ` Thomas Petazzoni
2015-01-06 10:05 ` Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 04/17] docs/manual: add documentation for the pkg-rebar infrastructure Johan Oudinet
2015-01-04 21:33 ` Thomas Petazzoni
2015-01-04 23:27 ` Yann E. MORIN
2015-01-04 23:39 ` Yann E. MORIN
2014-12-09 14:34 ` [Buildroot] [PATCH v4 05/17] erlang-goldrush: new package Johan Oudinet
2015-01-04 21:36 ` Thomas Petazzoni
2015-01-05 14:52 ` Johan Oudinet
2015-01-05 16:37 ` Thomas Petazzoni
2014-12-09 14:34 ` [Buildroot] [PATCH v4 06/17] erlang-lager: " Johan Oudinet
2015-01-04 21:37 ` Thomas Petazzoni
2015-01-05 16:10 ` Johan Oudinet
2015-01-05 16:38 ` Thomas Petazzoni [this message]
2015-01-05 23:53 ` Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 07/17] erlang-p1-zlib: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 08/17] erlang-p1-yaml: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 09/17] erlang-p1-xml: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 10/17] erlang-p1-utils: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 11/17] erlang-p1-tls: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 12/17] erlang-p1-stun: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 13/17] erlang-p1-stringprep: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 14/17] erlang-p1-sip: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 15/17] erlang-p1-iconv: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 16/17] erlang-p1-cache-tab: " Johan Oudinet
2014-12-09 14:34 ` [Buildroot] [PATCH v4 17/17] ejabberd: " Johan Oudinet
2015-01-05 0:06 ` [Buildroot] [PATCH v4 00/17] ejabberd: XMPP server Yann E. MORIN
2015-01-05 10:28 ` Johan Oudinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105173853.208d1884@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.