From: Dimitri Sivanich <sivanich@sgi.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: sgi-gru: gruhandles.c: Remove unused function
Date: Mon, 5 Jan 2015 13:39:49 -0600 [thread overview]
Message-ID: <20150105193949.GA18878@sgi.com> (raw)
In-Reply-To: <1420130807-29468-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Thu, Jan 01, 2015 at 05:46:47PM +0100, Rickard Strandqvist wrote:
> Remove the function tfh_restart() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/misc/sgi-gru/gruhandles.c | 6 ------
> drivers/misc/sgi-gru/gruhandles.h | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/gruhandles.c b/drivers/misc/sgi-gru/gruhandles.c
> index 2f30bad..1ee8e82 100644
> --- a/drivers/misc/sgi-gru/gruhandles.c
> +++ b/drivers/misc/sgi-gru/gruhandles.c
> @@ -196,12 +196,6 @@ void tfh_write_restart(struct gru_tlb_fault_handle *tfh,
> start_instruction(tfh);
> }
>
> -void tfh_restart(struct gru_tlb_fault_handle *tfh)
> -{
> - tfh->opc = TFHOP_RESTART;
> - start_instruction(tfh);
> -}
> -
> void tfh_user_polling_mode(struct gru_tlb_fault_handle *tfh)
> {
> tfh->opc = TFHOP_USER_POLLING_MODE;
> diff --git a/drivers/misc/sgi-gru/gruhandles.h b/drivers/misc/sgi-gru/gruhandles.h
> index 3f998b9..3d7bd36 100644
> --- a/drivers/misc/sgi-gru/gruhandles.h
> +++ b/drivers/misc/sgi-gru/gruhandles.h
> @@ -524,7 +524,6 @@ int tfh_write_only(struct gru_tlb_fault_handle *tfh, unsigned long paddr,
> int gaa, unsigned long vaddr, int asid, int dirty, int pagesize);
> void tfh_write_restart(struct gru_tlb_fault_handle *tfh, unsigned long paddr,
> int gaa, unsigned long vaddr, int asid, int dirty, int pagesize);
> -void tfh_restart(struct gru_tlb_fault_handle *tfh);
> void tfh_user_polling_mode(struct gru_tlb_fault_handle *tfh);
> void tfh_exception(struct gru_tlb_fault_handle *tfh);
>
> --
> 1.7.10.4
prev parent reply other threads:[~2015-01-05 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 16:46 [PATCH] misc: sgi-gru: gruhandles.c: Remove unused function Rickard Strandqvist
2015-01-05 19:39 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105193949.GA18878@sgi.com \
--to=sivanich@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.