All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Dec 2014, #05; Mon, 29)
Date: Mon, 5 Jan 2015 12:06:44 -0800	[thread overview]
Message-ID: <20150105200644.GJ29365@google.com> (raw)
In-Reply-To: <CAGZ79kbOnX7LVDB8d2Nw0629MvY+ojmy0kDWATM2Zj8NzPRgjQ@mail.gmail.com>

Stefan Beller wrote:
> On Mon, Dec 29, 2014 at 1:28 PM, Junio C Hamano <gitster@pobox.com> wrote:

>> * sb/copy-fd-errno (2014-11-17) 1 commit
>>  - copy.c: make copy_fd preserve meaningful errno
>>
>>  Will be rerolled as a part of a larger series.
>
> I am not expecting to reroll this as part of a larger series any more.
> So if this makes sense on its own, please pick it up?

I think the errno-based approach is problematic.  No callers today run
into the problem the patch fixes and if a caller did, I fear that
caller would be broken in other ways.

That said, no one seemed too excited about the alternative that
propagates the error message more explicitly with a strbuf.  I'd be
happy to re-send anyway, or I can work around this patch when
rerolling.

Thanks,
Jonathan

  reply	other threads:[~2015-01-05 20:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 21:28 What's cooking in git.git (Dec 2014, #05; Mon, 29) Junio C Hamano
2014-12-29 23:37 ` Philip Oakley
2014-12-30 15:55   ` Junio C Hamano
2015-01-02  0:18     ` Philip Oakley
2015-01-05 19:50 ` Stefan Beller
2015-01-05 20:06   ` Jonathan Nieder [this message]
2015-01-07  0:29     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105200644.GJ29365@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.