Re: Fix: Bind Cooling Device Weight

[Eduardo Valentin <edubezval@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Mon, Dec 29, 2014 at 10:40:21AM +0000, Javi Merino wrote:

<cut>

> 
> The patch "thermal: let governors have private data for each thermal
> zone" that you applied[0] allows you to do that.  Governors
> can have a bind_to_tz() op that can fail.  If it does, then the switch
> doesn't happen and you continue with the old governor.
> 
> [0] http://article.gmane.org/gmane.linux.power-management.general/54163
> 

Agreed.

Rui, the naming '.bind_to_tz()' seams to be appropriated here, even
considering the validation perspective you mentioned. Binding to a
thermal zone should be the best opportunity to check if the zone makes sense
for that governor. Don't you agree?

I think the .bind_to_tz() should be enough for both cases.

> Cheers,
> Javi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]