From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH 3/4] tools: libxl: code preparation for MBM Date: Tue, 6 Jan 2015 18:12:21 +0800 Message-ID: <20150106101221.GD3279@pengc-linux.bj.intel.com> References: <1419324880-13212-1-git-send-email-chao.p.peng@linux.intel.com> <1419324880-13212-4-git-send-email-chao.p.peng@linux.intel.com> <20150105122505.GD24360@zion.uk.xensource.com> <20150106094612.GB3279@pengc-linux.bj.intel.com> <20150106095137.GB14301@zion.uk.xensource.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150106095137.GB14301@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Tue, Jan 06, 2015 at 09:51:37AM +0000, Wei Liu wrote: > On Tue, Jan 06, 2015 at 05:46:12PM +0800, Chao Peng wrote: > [...] > > > Coding style, no space after "(" and before ")". > > > > > > I missed this issue when I reviewed your previous patches. You can fix > > > this style problem here while you're at it. > > Sure, I will fix them all. > > If you plan to fix them all and there are many instances, please use > preparatory patch -- don't mix them with functional changes. I noticed this. So I will certainly follow your suggestion :) Chao