From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: fix missing asm/alternative.h include in kernel/module.c
Date: Tue, 6 Jan 2015 10:40:08 +0000 [thread overview]
Message-ID: <20150106104008.GD4858@leverpostej> (raw)
In-Reply-To: <20150106015215.27249.86394.stgit@dusk.lan>
On Tue, Jan 06, 2015 at 01:52:20AM +0000, Paul Walmsley wrote:
> On next-20150105, defconfig compilation breaks with:
>
> arch/arm64/kernel/module.c:408:4: error: implicit declaration of function ?apply_alternatives? [-Werror=implicit-function-declaration]
>
> Fix by including asm/alternative.h, where the apply_alternatives()
> prototype is declared.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Paul Walmsley <pwalmsley@nvidia.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> ---
> arch/arm64/kernel/module.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c
> index fd027b101de5..ac081d6fe184 100644
> --- a/arch/arm64/kernel/module.c
> +++ b/arch/arm64/kernel/module.c
> @@ -27,6 +27,7 @@
> #include <linux/vmalloc.h>
> #include <asm/insn.h>
> #include <asm/sections.h>
> +#include <asm/alternative.h>
If this can move above the include of asm/insn.h:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
>
> #define AARCH64_INSN_IMM_MOVNZ AARCH64_INSN_IMM_MAX
> #define AARCH64_INSN_IMM_MOVK AARCH64_INSN_IMM_16
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-01-06 10:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 1:51 [PATCH 0/4] ARM64 compilation fixes for missing header includes Paul Walmsley
2015-01-06 1:52 ` [PATCH 1/4] arm64: fix missing asm/pgtable-hwdef.h include in asm/processor.h Paul Walmsley
2015-01-06 10:37 ` Mark Rutland
2015-01-06 20:34 ` Paul Walmsley
2015-01-06 1:52 ` [PATCH 2/4] arm64: fix missing linux/bug.h include in asm/arch_timer.h Paul Walmsley
2015-01-06 10:27 ` Mark Rutland
2015-01-06 20:30 ` Paul Walmsley
2015-01-06 1:52 ` [PATCH 3/4] arm64: fix missing asm/alternative.h include in kernel/module.c Paul Walmsley
2015-01-06 10:40 ` Mark Rutland [this message]
2015-01-06 20:36 ` Paul Walmsley
2015-01-06 1:52 ` [PATCH 4/4] arm64: fix missing asm/io.h include in kernel/smp_spin_table.c Paul Walmsley
2015-01-06 10:34 ` Mark Rutland
2015-01-06 20:32 ` Paul Walmsley
2015-01-07 11:08 ` [PATCH 0/4] ARM64 compilation fixes for missing header includes Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106104008.GD4858@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.