From: "J. Bruce Fields" <bfields@fieldses.org>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
Trond Myklebust <Trond.Myklebust@primarydata.com>,
linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/3] Remove function macros from nfs4_fs.h
Date: Tue, 6 Jan 2015 14:08:00 -0500 [thread overview]
Message-ID: <20150106190800.GB28003@fieldses.org> (raw)
In-Reply-To: <1C602278-4A23-4975-8339-7AFF0606B154@primarydata.com>
On Mon, Jan 05, 2015 at 03:31:46PM -0500, Weston Andros Adamson wrote:
> These patches look good to me, but have you tested them? ;)
>
> I mean, does anyone have a server that implements SP4_MACH_CRED to test against?
> When I originally developed this feature, I tested against a hacked nfsd…
> that code was really ugly (not ready for upstreaming), but allowed me to test the client
> feature.
>
> IRRC the server side is difficult because the server has to keep stateid to credential
> mappings, so when the machine cred was used it could check access against the acting cred.
>
> If there aren’t any servers to test this against, maybe we remove this feature? It can always
> be revived once there is a server to test against.
The Linux server should support MACH_CRED as of
57266a6e916e2522ea61758a3ee5576b60156791 "nfsd4: implement minimal
SP4_MACH_CRED". (Well, plus some later bugfixes.) But I think anything
since 3.14 should be OK.
That said, I wouldn't be surprised if it has problems. But please do
test against that and let me know....
--b.
next prev parent reply other threads:[~2015-01-06 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 19:17 [PATCH 0/3] Remove function macros from nfs4_fs.h Anna Schumaker
2015-01-05 19:17 ` [PATCH 1/3] nfs: Call nfs4_state_protect() from nfs4_proc_commit_setup() Anna Schumaker
2015-01-05 19:17 ` [PATCH 2/3] nfs: Call nfs4_state_protect_write() from nfs4_proc_write_setup() Anna Schumaker
2015-01-05 19:17 ` [PATCH 3/3] nfs: Remove unused v4 macros Anna Schumaker
2015-01-05 20:31 ` [PATCH 0/3] Remove function macros from nfs4_fs.h Weston Andros Adamson
2015-01-05 21:06 ` Anna Schumaker
2015-01-05 21:51 ` Weston Andros Adamson
2015-01-06 15:02 ` Weston Andros Adamson
2015-01-06 19:08 ` J. Bruce Fields [this message]
2015-01-07 18:47 ` Weston Andros Adamson
2015-01-07 18:55 ` J. Bruce Fields
2015-01-07 18:57 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106190800.GB28003@fieldses.org \
--to=bfields@fieldses.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.