DT support for OMAP3 ISP

DT support for OMAP3 ISP

[Ash Charles]

Hi,

I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
kernel.  It looks like there has been some work on dt-bindings for the
omap3isp (notably [1] and [2]) but I didn't see anything heading for
mainline.

What would be needed to support cameras using the omap3isp in a mainline kernel?

Thanks for any insight,
--Ash

[1] https://github.com/vaussard/linux/commits/overo-for-3.14/iommu/dt-v2
[2] http://git.linuxtv.org/cgit.cgi/sailus/media_tree.git/log/?h=rm696-043-dt

Re: DT support for OMAP3 ISP

[Tony Lindgren]

* Ash Charles <ashcharles@gmail.com> [150106 12:45]:
> Hi,
> 
> I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
> kernel.  It looks like there has been some work on dt-bindings for the
> omap3isp (notably [1] and [2]) but I didn't see anything heading for
> mainline.
> 
> What would be needed to support cameras using the omap3isp in a mainline kernel?

No idea about the camera, but at least the legacy omap DMA calls need
to be replaced or removed as the legacy DMA API will go away soon.

For the media code, these can be viewed with:

$ git grep omap_request_dma drivers/media/

Regards,

Tony
 
> [1] https://github.com/vaussard/linux/commits/overo-for-3.14/iommu/dt-v2
> [2] http://git.linuxtv.org/cgit.cgi/sailus/media_tree.git/log/?h=rm696-043-dt

Re: DT support for OMAP3 ISP

[Sakari Ailus]

Moikka,

On Tue, Jan 06, 2015 at 01:42:18PM -0800, Tony Lindgren wrote:
> * Ash Charles <ashcharles@gmail.com> [150106 12:45]:
> > Hi,
> > 
> > I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
> > kernel.  It looks like there has been some work on dt-bindings for the
> > omap3isp (notably [1] and [2]) but I didn't see anything heading for
> > mainline.
> > 
> > What would be needed to support cameras using the omap3isp in a mainline kernel?
> 
> No idea about the camera, but at least the legacy omap DMA calls need
> to be replaced or removed as the legacy DMA API will go away soon.

OMAP DMA is only used by the histogram block which can cope with PIO as well
--- I think there at least was a #define for it. That's not a reason not to
convert it however, it's just not as urgent it otherwise might be. I wonder
if someone has patches for that already.

Cc Laurent.

-- 
Terveisin,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Re: DT support for OMAP3 ISP

[Sakari Ailus]

(Fixed Laurent's e-mail.)

Moikka,

On Tue, Jan 06, 2015 at 01:42:18PM -0800, Tony Lindgren wrote:
> * Ash Charles <ashcharles@gmail.com> [150106 12:45]:
> > Hi,
> > 
> > I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
> > kernel.  It looks like there has been some work on dt-bindings for the
> > omap3isp (notably [1] and [2]) but I didn't see anything heading for
> > mainline.
> > 
> > What would be needed to support cameras using the omap3isp in a mainline kernel?
> 
> No idea about the camera, but at least the legacy omap DMA calls need
> to be replaced or removed as the legacy DMA API will go away soon.

OMAP DMA is only used by the histogram block which can cope with PIO as well
--- I think there at least was a #define for it. That's not a reason not to
convert it however, it's just not as urgent it otherwise might be. I wonder
if someone has patches for that already.

Cc Laurent.

-- 
Terveisin,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Re: DT support for OMAP3 ISP

[Ash Charles]

Thanks for the hints.

I tried the suggested branch adding omap3isp data to the Overo device
tree and device tree bindings for the mt9v032 device.  I needed to
manually modprobe omap3-isp but the camera was registered and I was
able to use media-ctl to manipulate the v4l2 pipeline.  I wasn't able
to stream as v4l2 was reporting "inappropriate ioctl"----old driver
perhaps?

I also tried changing the #define HIST_CONFIG_DMA 0 such that the
histogram block uses PIO instead of using the deprecated
omap_request_dma.  I saw basically the same behaviour.  What would be
the correct/modern way to use DMA here?

--Ash

On Tue, Jan 6, 2015 at 2:11 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> (Fixed Laurent's e-mail.)
>
> Moikka,
>
> On Tue, Jan 06, 2015 at 01:42:18PM -0800, Tony Lindgren wrote:
>> * Ash Charles <ashcharles@gmail.com> [150106 12:45]:
>> > Hi,
>> >
>> > I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
>> > kernel.  It looks like there has been some work on dt-bindings for the
>> > omap3isp (notably [1] and [2]) but I didn't see anything heading for
>> > mainline.
>> >
>> > What would be needed to support cameras using the omap3isp in a mainline kernel?
>>
>> No idea about the camera, but at least the legacy omap DMA calls need
>> to be replaced or removed as the legacy DMA API will go away soon.
>
> OMAP DMA is only used by the histogram block which can cope with PIO as well
> --- I think there at least was a #define for it. That's not a reason not to
> convert it however, it's just not as urgent it otherwise might be. I wonder
> if someone has patches for that already.
>
> Cc Laurent.
>
> --
> Terveisin,
>
> Sakari Ailus
> e-mail: sakari.ailus@iki.fi     XMPP: sailus@retiisi.org.uk

Re: DT support for OMAP3 ISP

[Ash Charles]

For what it is worth, I was able to get a MT9V032 camera  (caspa)
working with an OMAP3 using the suggested linux-media branch with
these two patches [1,2].  Thanks for the help :)

--Ash
[1] http://gumstix-misc.s3.amazonaws.com/patches/0001-First-cut-at-caspa-support-with-devicetree.patch
[2] http://gumstix-misc.s3.amazonaws.com/patches/0002-Pulling-in.patch

On Tue, Jan 6, 2015 at 6:41 PM, Ash Charles <ashcharles@gmail.com> wrote:
> Thanks for the hints.
>
> I tried the suggested branch adding omap3isp data to the Overo device
> tree and device tree bindings for the mt9v032 device.  I needed to
> manually modprobe omap3-isp but the camera was registered and I was
> able to use media-ctl to manipulate the v4l2 pipeline.  I wasn't able
> to stream as v4l2 was reporting "inappropriate ioctl"----old driver
> perhaps?
>
> I also tried changing the #define HIST_CONFIG_DMA 0 such that the
> histogram block uses PIO instead of using the deprecated
> omap_request_dma.  I saw basically the same behaviour.  What would be
> the correct/modern way to use DMA here?
>
> --Ash
>
> On Tue, Jan 6, 2015 at 2:11 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
>> (Fixed Laurent's e-mail.)
>>
>> Moikka,
>>
>> On Tue, Jan 06, 2015 at 01:42:18PM -0800, Tony Lindgren wrote:
>>> * Ash Charles <ashcharles@gmail.com> [150106 12:45]:
>>> > Hi,
>>> >
>>> > I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
>>> > kernel.  It looks like there has been some work on dt-bindings for the
>>> > omap3isp (notably [1] and [2]) but I didn't see anything heading for
>>> > mainline.
>>> >
>>> > What would be needed to support cameras using the omap3isp in a mainline kernel?
>>>
>>> No idea about the camera, but at least the legacy omap DMA calls need
>>> to be replaced or removed as the legacy DMA API will go away soon.
>>
>> OMAP DMA is only used by the histogram block which can cope with PIO as well
>> --- I think there at least was a #define for it. That's not a reason not to
>> convert it however, it's just not as urgent it otherwise might be. I wonder
>> if someone has patches for that already.
>>
>> Cc Laurent.
>>
>> --
>> Terveisin,
>>
>> Sakari Ailus
>> e-mail: sakari.ailus@iki.fi     XMPP: sailus@retiisi.org.uk

Re: DT support for OMAP3 ISP

[Sakari Ailus]

Hi Charles,

On Tue, Jan 06, 2015 at 12:42:12PM -0800, Ash Charles wrote:
> I'm playing with the Caspa camera (mt9v032) and Overo on the 3.17
> kernel.  It looks like there has been some work on dt-bindings for the
> omap3isp (notably [1] and [2]) but I didn't see anything heading for
> mainline.
> 
> What would be needed to support cameras using the omap3isp in a mainline kernel?
> 
> Thanks for any insight,
> --Ash
> 
> [1] https://github.com/vaussard/linux/commits/overo-for-3.14/iommu/dt-v2
> [2] http://git.linuxtv.org/cgit.cgi/sailus/media_tree.git/log/?h=rm696-043-dt

Please use this one instead:

It's much improved compared to what was there in the other branch:

<URL:http://vihersipuli.retiisi.org.uk/cgi-bin/gitweb.cgi?p=~sailus/linux.git;a=shortlog;h=refs/heads/rm696-046-dt>

That rebased on current media-tree.git doesn't work; for some reason the
IOMMU doesn't get bound correctly to the ISP DT node. Something to figure
out.

Indeed it's not in mainline yet, although the delta is a lot smaller than it
was back then, especially for the smiapp driver (which may not be relevant
for you though).

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk