From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:6522 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753581AbbAFXfd (ORCPT ); Tue, 6 Jan 2015 18:35:33 -0500 Date: Wed, 7 Jan 2015 10:18:46 +1100 From: Dave Chinner To: Christoph Hellwig Cc: "J. Bruce Fields" , Jeff Layton , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH 18/18] xfs: recall pNFS layouts on conflicting access Message-ID: <20150106231846.GE31508@dastard> References: <1420561721-9150-1-git-send-email-hch@lst.de> <1420561721-9150-19-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1420561721-9150-19-git-send-email-hch@lst.de> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Jan 06, 2015 at 05:28:41PM +0100, Christoph Hellwig wrote: > Recall all outstanding pNFS layouts and truncates, writes and similar extent > list modifying operations. This is not sufficient to isolate extent manipulations. mmap writes can trigger allocation through ->page_mkwrite, and can also trigger extent conversion at IO completion without first needing allocation. Maybe I'm missing something - this patchset needs some comments documenting the locking used in XFS to co-ordinate layout coherency at the client side with IO that is in progress for clients with overlapping block maps, as well as against server side application IO. Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id C35017FA6 for ; Tue, 6 Jan 2015 17:35:37 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id B2FF5304051 for ; Tue, 6 Jan 2015 15:35:34 -0800 (PST) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id FVdne5VCEewNqLCX for ; Tue, 06 Jan 2015 15:35:32 -0800 (PST) Date: Wed, 7 Jan 2015 10:18:46 +1100 From: Dave Chinner Subject: Re: [PATCH 18/18] xfs: recall pNFS layouts on conflicting access Message-ID: <20150106231846.GE31508@dastard> References: <1420561721-9150-1-git-send-email-hch@lst.de> <1420561721-9150-19-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1420561721-9150-19-git-send-email-hch@lst.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: "J. Bruce Fields" , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, Jeff Layton , xfs@oss.sgi.com On Tue, Jan 06, 2015 at 05:28:41PM +0100, Christoph Hellwig wrote: > Recall all outstanding pNFS layouts and truncates, writes and similar extent > list modifying operations. This is not sufficient to isolate extent manipulations. mmap writes can trigger allocation through ->page_mkwrite, and can also trigger extent conversion at IO completion without first needing allocation. Maybe I'm missing something - this patchset needs some comments documenting the locking used in XFS to co-ordinate layout coherency at the client side with IO that is in progress for clients with overlapping block maps, as well as against server side application IO. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 18/18] xfs: recall pNFS layouts on conflicting access Date: Wed, 7 Jan 2015 10:18:46 +1100 Message-ID: <20150106231846.GE31508@dastard> References: <1420561721-9150-1-git-send-email-hch@lst.de> <1420561721-9150-19-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "J. Bruce Fields" , Jeff Layton , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <1420561721-9150-19-git-send-email-hch-jcswGhMUV9g@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jan 06, 2015 at 05:28:41PM +0100, Christoph Hellwig wrote: > Recall all outstanding pNFS layouts and truncates, writes and similar extent > list modifying operations. This is not sufficient to isolate extent manipulations. mmap writes can trigger allocation through ->page_mkwrite, and can also trigger extent conversion at IO completion without first needing allocation. Maybe I'm missing something - this patchset needs some comments documenting the locking used in XFS to co-ordinate layout coherency at the client side with IO that is in progress for clients with overlapping block maps, as well as against server side application IO. Cheers, Dave. -- Dave Chinner david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html