From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Ben Widawsky" <ben@bwidawsk.net>,
"Deepak M" <m.deepak@intel.com>,
intel-gfx@lists.freedesktop.org,
"Kristian Høgsberg" <hoegsberg@gmail.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] Revert "drm/i915: Parsing LFP brightness control from VBT"
Date: Wed, 7 Jan 2015 09:47:06 +0100 [thread overview]
Message-ID: <20150107084706.GC26519@phenom.ffwll.local> (raw)
In-Reply-To: <87y4pfyouh.fsf@intel.com>
On Wed, Jan 07, 2015 at 10:30:46AM +0200, Jani Nikula wrote:
> On Wed, 07 Jan 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Jan 06, 2015 at 02:48:15PM -0500, Rodrigo Vivi wrote:
> >> This reverts commit 371abae844ede392066bfc21202b2e40f4a654d1.
> >>
> >> This data seems unreliable and causing many issues and blocking other
> >> teams and feature implementation. Safest way is to revert that for now.
> >>
> >> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=88081
> >> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=88039
>
> IMO s/Reference/Bugzilla/
Yup, Bugzilla is for bugs fixed by this patch, References: is more for fyi
stuff and mailing lists. Regressions should always have a bugzilla,
otherwise QA has let something slip through.
>
> Also
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87671
>
> >> Cc: Ben Widawsky <ben@bwidawsk.net>
> >> Cc: Kristian Høgsberg <hoegsberg@gmail.com>
> >> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > Cc: Vandana Kannan <vandana.kannan@intel.com>
> > Cc: Deepak M <m.deepak@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> >
> > When submitting a revert please include the cc/submitter/reviewers from
> > the original patch too. I've done that now.
>
> The code agrees with the spec, but the VBT on these machines quite
> obviously does not agree with the spec.
>
> Vandana, I think you're in a better position than us to figure out
> what's going on with VBT vs. the spec.
>
> Daniel, please just pick this up now.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-01-07 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 19:48 [PATCH] Revert "drm/i915: Parsing LFP brightness control from VBT" Rodrigo Vivi
2015-01-07 8:16 ` Daniel Vetter
2015-01-07 8:30 ` Jani Nikula
2015-01-07 8:47 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107084706.GC26519@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=hoegsberg@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=m.deepak@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.