Re: [meta-oe][PATCH 1/2] log4c: fix expat rdepends issue

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]

On Tue, Jan 06, 2015 at 06:25:45PM -0800, akuster808 wrote:
> 
> 
> On 01/06/2015 08:28 AM, Martin Jansa wrote:
> > On Tue, Jan 06, 2015 at 08:01:06AM -0800, Armin Kuster wrote:
> >> add --without-expat
> >>
> >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> >> ---
> >>   meta-oe/recipes-support/log4c/log4c_1.2.4.bb | 4 +++-
> >>   1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/meta-oe/recipes-support/log4c/log4c_1.2.4.bb b/meta-oe/recipes-support/log4c/log4c_1.2.4.bb
> >> index 43e0746..0e58db7 100644
> >> --- a/meta-oe/recipes-support/log4c/log4c_1.2.4.bb
> >> +++ b/meta-oe/recipes-support/log4c/log4c_1.2.4.bb
> >> @@ -12,5 +12,7 @@ S = "${WORKDIR}/${PN}-${PV}"
> >>
> >>   EXTRA_OECONF = "--prefix=/usr"
> >>
> >> -inherit autotools
> >> +PACKAGECONFIG ??=""
> >> +PACKAGECONFIG[expat] = ", --without-expat, expat, expat"
> >
> > Is explicit expat runtime dependency needed when enabled?
> 
> Yep, need both. rdepends by itself did not fix the compile issue I saw.

I'm not suggesting dumping rdepends, I meant that depends should be
enough (rdepends is set automatically)

>  
> /home/akuster/oss/mywork/poky/build/tmp/work/core2-64-poky-linux/log4c/1.2.4-r0/log4c-1.2.4/src/sd/domnode-expat.c:51:19: 
> fatal error: expat.h: No such file or directory
> |  #include <expat.h>
> |                    ^
> | compilation terminated.
> | make[4]: *** [domnode-expat.lo] Error 1
> 
> 
> - armin
> >
> > It was detected by dependency test so I don't think so (so it's
> > correctly added by shlibs providers when enabled/detected).
> >
> >> +inherit autotools
> >> --
> >> 1.9.1
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> >
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]