From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] VT-d: don't crash when PTE bits 52 and up are non-zero Date: Wed, 7 Jan 2015 10:00:22 -0500 Message-ID: <20150107150022.GG30457@l.oracle.com> References: <5494196B0200007800050F6B@mail.emea.novell.com> <54AD155B0200007800052364@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Y8s62-0005f0-VG for xen-devel@lists.xenproject.org; Wed, 07 Jan 2015 15:00:31 +0000 Content-Disposition: inline In-Reply-To: <54AD155B0200007800052364@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Yang Z Zhang , xen-devel , Kevin Tian List-Id: xen-devel@lists.xenproject.org On Wed, Jan 07, 2015 at 10:15:39AM +0000, Jan Beulich wrote: > >>> On 23.12.14 at 07:52, wrote: > >> From: Jan Beulich [mailto:JBeulich@suse.com] > >> Sent: Friday, December 19, 2014 7:26 PM > >> > >> This can (and will) be legitimately the case when sharing page tables > >> with EPT (more of a problem before p2m_access_rwx became zero, but > >> still possible even now when other than that is the default for a > >> guest), leading to an unconditional crash (in print_vtd_entries()) > >> when a DMA remapping fault occurs. > > > > could you elaborate the scenarios when bits 52+ are non-zero? > > > >> > >> Signed-off-by: Jan Beulich > > > > but the changes looks reasonable to me. > > > > Signed-off-by: Kevin Tian > > I translated this to a Reviewed-by, as S-o-b doesn't seem to make > sense here. > > Konrad - please indicate whether this can also go into 4.5. Yes. Release-Acked-by: Konrad Rzeszutek Wilk > > Jan >