All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: sakshi <sakshi.april5@gmail.com>
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
	gclement@baobob.org, guido@vanguardiasur.com.ar, shack@linux.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed line over 80 characters warning
Date: Wed, 7 Jan 2015 10:12:21 -0800	[thread overview]
Message-ID: <20150107181221.GA6644@kroah.com> (raw)
In-Reply-To: <1420650446-21507-1-git-send-email-sakshi.april5@gmail.com>

On Wed, Jan 07, 2015 at 10:37:26PM +0530, sakshi wrote:
> Signed-off-by: sakshi <sakshi.april5@gmail.com>

Your subject needs to provide a little bit more data, as what part of
the kernel you are modifying, and the like.  Look at existing patches
for examples of this.

Also, we need a changelog body, saying what you are doing.

And finally, we need a "full" name for the From: and signed-off-by:
line, I doubt you sign legal documents with just those 6 letters, right?

Please fix up and resend.

thanks,

greg k-h

  reply	other threads:[~2015-01-07 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 17:07 [PATCH] Fixed line over 80 characters warning sakshi
2015-01-07 18:12 ` Greg KH [this message]
2015-01-08 14:34   ` [Discarding old patch and resending new one] Fixed line over 80 characters for drivers/staging/vt6655/baseband.c by splitting the line into two Sakshi Bansal
2015-01-08 15:09     ` Dan Carpenter
2015-01-08 16:37       ` [Discarding old patch and resending new one] Staging: vt6655: baseband.c: fixed line over 80 characters Sakshi Bansal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107181221.GA6644@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gclement@baobob.org \
    --cc=guido@vanguardiasur.com.ar \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sakshi.april5@gmail.com \
    --cc=shack@linux.com \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.