All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fixed line over 80 characters warning
@ 2015-01-07 17:07 sakshi
  2015-01-07 18:12 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: sakshi @ 2015-01-07 17:07 UTC (permalink / raw)
  To: forest
  Cc: gregkh, tvboxspy, gclement, guido, shack, devel, linux-kernel,
	sakshi

Signed-off-by: sakshi <sakshi.april5@gmail.com>
---
 drivers/staging/vt6655/baseband.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 86c72ba..c138f9b 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -27,7 +27,8 @@
  *
  * Functions:
  *      BBuGetFrameTime        - Calculate data frame transmitting time
- *      BBvCaculateParameter   - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx
+ *      BBvCaculateParameter   - Caculate PhyLength, PhyService and Phy Signal
+ *                               parameter for baseband Tx
  *      BBbReadEmbedded         - Embedded read baseband register via MAC
  *      BBbWriteEmbedded        - Embedded write baseband register via MAC
  *      BBbVT3253Init          - VIA VT3253 baseband chip init code
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fixed line over 80 characters warning
  2015-01-07 17:07 [PATCH] Fixed line over 80 characters warning sakshi
@ 2015-01-07 18:12 ` Greg KH
  2015-01-08 14:34   ` [Discarding old patch and resending new one] Fixed line over 80 characters for drivers/staging/vt6655/baseband.c by splitting the line into two Sakshi Bansal
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2015-01-07 18:12 UTC (permalink / raw)
  To: sakshi; +Cc: forest, tvboxspy, gclement, guido, shack, devel, linux-kernel

On Wed, Jan 07, 2015 at 10:37:26PM +0530, sakshi wrote:
> Signed-off-by: sakshi <sakshi.april5@gmail.com>

Your subject needs to provide a little bit more data, as what part of
the kernel you are modifying, and the like.  Look at existing patches
for examples of this.

Also, we need a changelog body, saying what you are doing.

And finally, we need a "full" name for the From: and signed-off-by:
line, I doubt you sign legal documents with just those 6 letters, right?

Please fix up and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Discarding old patch and resending new one] Fixed line over 80 characters for drivers/staging/vt6655/baseband.c by splitting the line into two
  2015-01-07 18:12 ` Greg KH
@ 2015-01-08 14:34   ` Sakshi Bansal
  2015-01-08 15:09     ` Dan Carpenter
  0 siblings, 1 reply; 5+ messages in thread
From: Sakshi Bansal @ 2015-01-08 14:34 UTC (permalink / raw)
  To: forest
  Cc: gregkh, tvboxspy, gclement, guido, shack, devel, linux-kernel,
	Sakshi Bansal

Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com>
---
 drivers/staging/vt6655/baseband.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 86c72ba..c138f9b 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -27,7 +27,8 @@
  *
  * Functions:
  *      BBuGetFrameTime        - Calculate data frame transmitting time
- *      BBvCaculateParameter   - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx
+ *      BBvCaculateParameter   - Caculate PhyLength, PhyService and Phy Signal
+ *                               parameter for baseband Tx
  *      BBbReadEmbedded         - Embedded read baseband register via MAC
  *      BBbWriteEmbedded        - Embedded write baseband register via MAC
  *      BBbVT3253Init          - VIA VT3253 baseband chip init code
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Discarding old patch and resending new one] Fixed line over 80 characters for drivers/staging/vt6655/baseband.c by splitting the line into two
  2015-01-08 14:34   ` [Discarding old patch and resending new one] Fixed line over 80 characters for drivers/staging/vt6655/baseband.c by splitting the line into two Sakshi Bansal
@ 2015-01-08 15:09     ` Dan Carpenter
  2015-01-08 16:37       ` [Discarding old patch and resending new one] Staging: vt6655: baseband.c: fixed line over 80 characters Sakshi Bansal
  0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2015-01-08 15:09 UTC (permalink / raw)
  To: Sakshi Bansal
  Cc: forest, devel, gclement, shack, tvboxspy, gregkh, linux-kernel

Read: https://www.google.com/search?q=how+to+write+a+v2+patch

The subject is still messed up and there is no changelog.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Discarding old patch and resending new one] Staging: vt6655: baseband.c: fixed line over 80 characters
  2015-01-08 15:09     ` Dan Carpenter
@ 2015-01-08 16:37       ` Sakshi Bansal
  0 siblings, 0 replies; 5+ messages in thread
From: Sakshi Bansal @ 2015-01-08 16:37 UTC (permalink / raw)
  To: forest
  Cc: gregkh, tvboxspy, gclement, guido, shack, devel, linux-kernel,
	Sakshi Bansal

Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com>
---
 drivers/staging/vt6655/baseband.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 86c72ba..c138f9b 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -27,7 +27,8 @@
  *
  * Functions:
  *      BBuGetFrameTime        - Calculate data frame transmitting time
- *      BBvCaculateParameter   - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx
+ *      BBvCaculateParameter   - Caculate PhyLength, PhyService and Phy Signal
+ *                               parameter for baseband Tx
  *      BBbReadEmbedded         - Embedded read baseband register via MAC
  *      BBbWriteEmbedded        - Embedded write baseband register via MAC
  *      BBbVT3253Init          - VIA VT3253 baseband chip init code
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-08 16:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-07 17:07 [PATCH] Fixed line over 80 characters warning sakshi
2015-01-07 18:12 ` Greg KH
2015-01-08 14:34   ` [Discarding old patch and resending new one] Fixed line over 80 characters for drivers/staging/vt6655/baseband.c by splitting the line into two Sakshi Bansal
2015-01-08 15:09     ` Dan Carpenter
2015-01-08 16:37       ` [Discarding old patch and resending new one] Staging: vt6655: baseband.c: fixed line over 80 characters Sakshi Bansal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.