From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754295AbbAGS2t (ORCPT ); Wed, 7 Jan 2015 13:28:49 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35815 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753691AbbAGS2r (ORCPT ); Wed, 7 Jan 2015 13:28:47 -0500 X-Sasl-enc: PYZoTstwNXliUZPt6m4OeamsuPeZ998MqKz6AunKIM7B 1420655326 Date: Wed, 7 Jan 2015 10:28:45 -0800 From: Greg KH To: John Stultz Cc: lkml , Sasha Levin , Thomas Gleixner , Ingo Molnar , stable , Andy Lutomirski Subject: Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user Message-ID: <20150107182845.GA7699@kroah.com> References: <1420654340-3009-1-git-send-email-john.stultz@linaro.org> <1420654340-3009-2-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1420654340-3009-2-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 07, 2015 at 10:12:19AM -0800, John Stultz wrote: > From: Sasha Levin > > An unvalidated user input is multiplied by a constant, which can result in > an undefined behaviour for large values. While this is validated later, > we should avoid triggering undefined behaviour. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: stable > Cc: Andy Lutomirski > Signed-off-by: Sasha Levin > [jstultz: include trivial milisecond->microsecond correction noticed > by Andy] > Signed-off-by: John Stultz > --- > include/linux/time.h | 13 +++++++++++++ > kernel/time/time.c | 4 ++++ > 2 files changed, 17 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.